Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2646004pxa; Mon, 24 Aug 2020 22:07:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1UsYuX/GQfttLnjpO/oz0kw1TaKvkVjS6SWMgW46i4yekzsZ0yLxeN7VfJVe2fIyjRtNp X-Received: by 2002:a17:906:5812:: with SMTP id m18mr8809100ejq.66.1598332076080; Mon, 24 Aug 2020 22:07:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598332076; cv=none; d=google.com; s=arc-20160816; b=ZCTAa0onf0KIyH91wMg0m7b89O9PnnDVuajKz0XshTF102o1dKKkPw5YWNRvEGf69+ 3RiWfn/1xSHkZBy+zsMQ2ZS9uiFOZATC966Llwy6y7+Htlp5iIwx6axi26WdxL2iZrBZ LXm8U/DQ+SQcWGw9PaOFXeSKyLHFDI7k4kio5/0TgebXoqTGIFwRxpsbuHEAMoDXzrD9 k3k30FFQjBC97uWsf8Tsocio6RvJ0D0Ghix2ogYeQurm+SS0fd9XIk3ToMTw/29+cF7g y5HNlaG98UOsRT4vnDxRv15rLJncxnYHv8EElHTIPdWBQB9kdAeZ/39Uw0ipdbHgIzTW Jflw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=688oYd6e5D8IzYjKZP34ak3ZtV4VAinzPzl85Ke/zas=; b=BtzC/aGbznNES0KqWxfSib72/WXiQxlkzU/E/STWcDnOGheylzkRYTz+BinV/kjDEv bPnB04gaKlZVQJfGy5t7FLh5zGKS7xCKCQi/A99tbYyBj/9Vjt+4FrR3q6IwmhdL63ql Wy01oZ3NpByP1pXzz5933Gh6LND0zTSKcqK/KA92cQ4cMJrIL7zTUhBsiI7CAxwyHA5v b40kjmlPaNa7ipZljbqclEvPNKfGUcIKzwqW/GM8YJucdkghmwsoBmd1XbNFzid+pZd1 dLGYZLDRdKDO1LXSrkOoUbIr+xRpjKzL8PC6PwLk+GHTih4fTOhEEOx5deEKPsI70prn DXeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u18si7959455ejr.600.2020.08.24.22.07.33; Mon, 24 Aug 2020 22:07:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728923AbgHYE5d (ORCPT + 99 others); Tue, 25 Aug 2020 00:57:33 -0400 Received: from smtprelay0198.hostedemail.com ([216.40.44.198]:59242 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728875AbgHYE5Y (ORCPT ); Tue, 25 Aug 2020 00:57:24 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id B4CE01E09; Tue, 25 Aug 2020 04:57:23 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:541:800:857:960:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1541:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3353:3743:3865:3866:3867:3868:3870:3874:4321:5007:6261:7903:8879:10004:10848:11658:11914:12296:12297:12555:12895:13069:13311:13357:13894:14096:14181:14384:14394:14721:21067:21080:21524:21627:21773:30054:30075:30079,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: roll40_43024e127059 X-Filterd-Recvd-Size: 2151 Received: from joe-laptop.perches.com (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Aug 2020 04:57:22 +0000 (UTC) From: Joe Perches To: Jiri Kosina , linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 22/29] video: fbdev: Avoid comma separated statements Date: Mon, 24 Aug 2020 21:56:19 -0700 Message-Id: <3e56046e67e583ac93030297ff6d58c08ca54086.1598331149.git.joe@perches.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use semicolons and braces. Signed-off-by: Joe Perches --- drivers/video/fbdev/tgafb.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/tgafb.c b/drivers/video/fbdev/tgafb.c index e9869135d833..666fbe2f671c 100644 --- a/drivers/video/fbdev/tgafb.c +++ b/drivers/video/fbdev/tgafb.c @@ -989,8 +989,10 @@ tgafb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) /* We can fill 2k pixels per operation. Notice blocks that fit the width of the screen so that we can take advantage of this and fill more than one line per write. */ - if (width == line_length) - width *= height, height = 1; + if (width == line_length) { + width *= height; + height = 1; + } /* The write into the frame buffer must be aligned to 4 bytes, but we are allowed to encode the offset within the word in @@ -1171,8 +1173,10 @@ copyarea_8bpp(struct fb_info *info, u32 dx, u32 dy, u32 sx, u32 sy, More than anything else, these control how we do copies. */ depos = dy * line_length + dx; sepos = sy * line_length + sx; - if (backward) - depos += width, sepos += width; + if (backward) { + depos += width; + sepos += width; + } /* Next copy full words at a time. */ n32 = width / 32; -- 2.26.0