Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2646965pxa; Mon, 24 Aug 2020 22:09:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybiaMAHTjT59lM0ePjAtM6Ksz3YznS2LRO/vX7kcYEiDQQHZMfYHg8yy0XZwvdz9jDn54o X-Received: by 2002:a17:906:4755:: with SMTP id j21mr9370806ejs.422.1598332197737; Mon, 24 Aug 2020 22:09:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598332197; cv=none; d=google.com; s=arc-20160816; b=Wfuxys88DoFaVDnr6ftec35RtUR/YyUHzF6PPF1QsGIIUjdWisXOhWLEx28WpmGpIZ 9eAfMN3C75TOpkOnrMRG44Kp7Y9Tyqi/YqPh9stUOF3mP+up6xYYtONZsD8XeRhTr2H/ hWNu4NBf/PO/0X5Ipz7/AyfrnNxnzDuIAYQ/ZTsifSjzYqgy5Sql1QH7yafq1pM4wwQI jo1tepNdU8Mw2gNacAIns5h1mJWVNZO97tApfjAUxoTCtPq4M/0LmHOp+0LkCbpEWfzn 4Dtpenp88y3SoV7BTVnNhYQrb24akpKQBbpZgiJknZ8UKBOxyRG5wcqcmg4ACLgRE7hw Cp/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=mTMO/aMxwQDvm4QyKerNHt+zHI7aI/wWBpDJ1BtwZNI=; b=jUaYdQ2IfgE4rP6ZR9QQyPOKFxh7vR35KC+tG6Nz+gF3TKl16I6G+syWSb5Txf87+S +QtGsUIKCFuQmduwJ+x6+8J3GlDjTHNM/mb7Y2vIP6Wmo8hXIKDlk6qWEtwLVltimhTe iPv2AWMkK3y2A/zs1VXQta/Oh9YMB5rIi+U4Rgb2N+47FSJmJiYRzwDuxOtaITQce4cl AbSKSF+XKJ9/uK1aPAVprdnuChwG5OZbDqHf4xunk8lSL6DP6udMqVD3tGMiVh1YN/4d fYJBsknjjX9GG6D7CQXzwW6goWF8JPYyGw9sC4Jb+gSb6+W6tHmMQZ+dhMh04w2mVzBT xe0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si10060881edb.127.2020.08.24.22.09.35; Mon, 24 Aug 2020 22:09:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728528AbgHYFHO (ORCPT + 99 others); Tue, 25 Aug 2020 01:07:14 -0400 Received: from mga03.intel.com ([134.134.136.65]:61368 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbgHYFHM (ORCPT ); Tue, 25 Aug 2020 01:07:12 -0400 IronPort-SDR: mboV5hj4gJSSAVPp8AnRTwClfsxC1O/OOV2nkC7TuT+pAX7U0TmWd8JDH3YfuWBEvpz02emysT RInsmn4icgjQ== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="156037450" X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="156037450" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2020 22:07:11 -0700 IronPort-SDR: tpzExRGhkoQqxP5Rctfqoor01FgB+RS41SQ9/FprnaOo2OYBngnuRRdMGioCTFdeYCESQ+FdAQ 3hF7i29NGY1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="322617343" Received: from sgsxdev001.isng.intel.com (HELO localhost) ([10.226.88.11]) by fmsmga004.fm.intel.com with ESMTP; 24 Aug 2020 22:07:08 -0700 From: Rahul Tanwar To: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, lee.jones@linaro.org Cc: thierry.reding@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andriy.shevchenko@intel.com, songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com, Rahul Tanwar Subject: [PATCH v11 0/2] pwm: intel: Add PWM driver for a new SoC Date: Tue, 25 Aug 2020 13:07:04 +0800 Message-Id: X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch 1 adds dt binding document in YAML format. Patch 2 add PWM fan controller driver for LGM SoC. v11: - Address below review concerns (Andy Shevchenko) * Fix a issue with dev_err_probe() usage & improve the usage. * Fix & improve a ordering issue with clk_enable/disable & reset_control assert/deassert. v10: - Removed unused of_device.h and added platform_device.h & mod_devicetable.h v9: - Address code quality related review concerns (Andy Shevchenko) - Use devm_add_action_or_reset() instead of explicit unwind calls. v8: - Remove fan related optional properties usage, keep them as default. If needed, change pwm-fan driver separately in future to add them as generic properties. v7: - Address code quality related review concerns. - Rename fan related property to pwm-*. - Fix one make dt_binding_check reported error. v6: - Readjust .apply op as per review feedback. - Add back pwm-cells property to resolve make dt_binding_check error. pwm-cells is a required property for PWM driver. - Add back fan related optional properties. v5: - Address below review concerns from Uwe Kleine-K?nig. * Improve comments about Limitations. * Use return value of regmap_update_bits if container function returns error code. * Modify .apply op to have strict checking for fixed period supported by PWM HW. * Use u64 as type when use min_t for duty_cycle. * Add reset_control_assert() in failure case in probe where it was missing earlier. - Remove fan specific optional properties from pwm dt binding document (Rob Herring) v4: - Address below review concerns from Uwe Kleine-K?nig. * Improve notes and limitations comments. * Add common prefixes for all #defines. * Modify/Improve logic in .apply & .get_state ops as advised. * Skip error messages in probe when error is -EPROBE_DEFER. * Add dependencies in Kconfig (OF & HAS_IOMEM) and add select REGMAP_MMIO. * Address other code quality related review concerns. - Fix make dt_binding_check reported error in YAML file. v3: - Address below review concerns from Uwe Kleine-K?nig. * Remove fan rpm calibration task from the driver. * Modify apply op as per the review feedback. * Add roundup & round down where necessary. * Address other misc code quality related review concerns. * Use devm_reset_control_get_exclusive(). (Philipp Zabel) * Improve dt binding document. v2: - Address below review concerns from Uwe Kleine-K?nig. * Add notes and limitations about PWM HW. * Rename all functions and structure to lgm_pwm_* * Readjust space aligninment in structure fields to single space. * Switch to using apply instead of config/enable/disable. * Address other code quality related concerns. * Rebase to 5.8-rc1. - Address review concerns in dt binding YAML from Rob Herring. v1: - Initial version. Rahul Tanwar (2): Add DT bindings YAML schema for PWM fan controller of LGM SoC Add PWM fan controller driver for LGM SoC .../devicetree/bindings/pwm/intel,lgm-pwm.yaml | 44 ++++ drivers/pwm/Kconfig | 11 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-intel-lgm.c | 253 +++++++++++++++++++++ 4 files changed, 309 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml create mode 100644 drivers/pwm/pwm-intel-lgm.c -- 2.11.0