Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   25 Aug 2020 15:46:00 +0900
Message-ID: <87lfi3w7hj.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <robh+dt@kernel.org>, <lgirdwood@gmail.com>,
        <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
        <mkumard@nvidia.com>, <viswanathl@nvidia.com>,
        <rlokhande@nvidia.com>, <dramesh@nvidia.com>,
        <atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
        <swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
In-Reply-To: <e9698ac3-0a2e-08a2-3f78-b0be0069d6ee@nvidia.com>
References: <1596605064-27748-1-git-send-email-spujar@nvidia.com>
        <1596605064-27748-4-git-send-email-spujar@nvidia.com>
        <87pn7ofs19.wl-kuninori.morimoto.gx@renesas.com>
        <97f325a6-96cc-11c5-8027-8c0a159e3da0@nvidia.com>
        <2d3aa11e-3c56-1f7a-3d41-2457f973d55b@nvidia.com>
        <87sgcbwcnf.wl-kuninori.morimoto.gx@renesas.com>
        <14691a05-cb29-a030-0e72-eca900d8eb7e@nvidia.com>
        <87o8mzwajg.wl-kuninori.morimoto.gx@renesas.com>
        <e9698ac3-0a2e-08a2-3f78-b0be0069d6ee@nvidia.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Sameer

> > Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex().
> > I'm not sure which style is best.
> 
> I don't know how complex it is to have a unified solution. But if we
> can protect snd_soc_find_dai() itself, things would be simpler may be
> in long term. Right now there are separate source files for soc-core,
> soc-dai and soc-component, but because of two approaches looks like
> the function need to be moved around and need to be placed in
> soc-core. Also the issue might go unnoticed if LOCKDEP is not enabled.
> 
> May be start with a wrapper for now and eventually unify?

Yeah, it seems has _with_mutex() can be better idea.
I'm posting patch, but I noticed that Mark's branch vs Linus branch
have some mismatch (?), and now I'm asking it to him.
I can post _with_mutex() version as v2 if I could get answer.
After that I'm happy your next patch can re-use it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto