Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Aug 2020 09:10:43 +0200
From:   Johan Hovold <johan@kernel.org>
To:     "Xia, Hui" <hui.xia@intel.com>
Cc:     Johan Hovold <johan@kernel.org>, lkp <lkp@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild-all] Re: drivers/greybus/es2.c:439 message_send() error:
 double unlocked 'es2->cport_out_urb_lock' (orig line 417)
Message-ID: <20200825071043.GJ21288@localhost>
References: <202008140324.LLig4g2M%lkp@intel.com>
 <20200824095342.GF21288@localhost>
 <MWHPR11MB1613967593B79A01BE785F03E5570@MWHPR11MB1613.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <MWHPR11MB1613967593B79A01BE785F03E5570@MWHPR11MB1613.namprd11.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 25, 2020 at 02:37:04AM +0000, Xia, Hui wrote:
> >-----Original Message-----
> >From: Johan Hovold <johan@kernel.org>
> >Sent: 2020年8月24日 17:54
> >To: kernel test robot <lkp@intel.com>
> >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; kbuild-all@lists.01.org;
> >linux-kernel@vger.kernel.org
> >Subject: [kbuild-all] Re: drivers/greybus/es2.c:439 message_send() error: double
> >unlocked 'es2->cport_out_urb_lock' (orig line 417)
> >
> >On Fri, Aug 14, 2020 at 03:26:27AM +0800, kernel test robot wrote:
> >> Hi Greg,
> >>
> >> First bad commit (maybe != root cause):
> >>
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >> head:   dc06fe51d26efc100ac74121607c01a454867c91
> >> commit: b81beec9cb2d586412c7166c893894930f19965e staging: greybus:
> >move es2 to drivers/greybus/
> >> date:   12 months ago
> >> config: x86_64-randconfig-m001-20200813 (attached as .config)
> >> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> >>
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot <lkp@intel.com>
> >>
> >> New smatch warnings:
> >> drivers/greybus/es2.c:439 message_send() error: double unlocked
> >> 'es2->cport_out_urb_lock' (orig line 417)
> >> drivers/greybus/es2.c:879 cport_out_callback() error: double unlocked
> >> 'es2->cport_out_urb_lock' (orig line 871)
> >> drivers/greybus/es2.c:1018 arpc_sync() error: double unlocked
> >> 'es2->arpc_lock' (orig line 992)
> >>
> >> Old smatch warnings:
> >> drivers/greybus/es2.c:441 message_send() error: double unlocked
> >> 'es2->cport_out_urb_lock' (orig line 439)
> >
> >None of these warnings make any sense. Is the robot drunk?

> It is a false positive. Please kindly ignore.
> There was a bug in robot that sent unconfident reports out directly
> and has been fixed. Sorry for inconvenient.

Ok, thanks for confirming.

Johan