Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: eNmFQX5PpPmcEviaQ2tfOjEkWWdWkKRzvrImmUXl5mVRrlUFPtqZ1wE+lK5yUYBsvhcmqsJCih
 WZDOx5VMYDnh/viACzRfE1Tkh+vbv8SOTGngblCPqnNJLtiYDqHBsS5aA5nttEjVzxD8QJC3I7
 ex0xbFCkwsEMSF4s6ua0kKt75D+5gMj+RgDujclKkAP8wBUQcuoyiwyYCv9HyUg4fj5mw8T5nS
 YdSyBiigWoxxCAXJ4Z56l3KNpG2OmZkMQYvXTzJvIQI35XhVFRjkMSh1p9SzyhUAXp+PfZ4NFG
 UCs=
IronPort-SDR: Mo8sm6JNKdJHPOvnPGZCJUM1pHbd62JlnrYNHSQgJoCMunDMl/YvYKBGo/yinevAYV9fXAP/dm
 /N+Bn7rRGKn+6l2bl09VCsiCxkYyPE2Y/rmrtBKTia197y7YgLR10w/PNaGf9dGkJUOGd/1rFn
 8qBVKRuQKPewSYPNAY1bruwsF8E7N67Z/3slrcCdP1CmsG2HAdsoMrjAhx63ZU6m5BDP5Eg+zg
 Z/TbokoBRUguSjMRQNg/JF5yOx52odm/yjXG0ZnZI5tB3Bia0cYgNTus5WzDoZWHYBc6fbdP0X
 YMg=
Message-ID: <4b7d57738ce8e2130c4740a0f3f973fbaf60a7cf.camel@ew.tq-group.com>
Subject: Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Tue, 25 Aug 2020 09:22:23 +0200
In-Reply-To: <CAOMZO5DSX1pf3xxo=CGvgPmHcjMJoWFx74grVJBckSmjtF-RGg@mail.gmail.com>
References: <20200824091013.20640-1-matthias.schiffer@ew.tq-group.com>
         <20200824091013.20640-2-matthias.schiffer@ew.tq-group.com>
         <CAOMZO5DSX1pf3xxo=CGvgPmHcjMJoWFx74grVJBckSmjtF-RGg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2020-08-24 at 18:36 -0300, Fabio Estevam wrote:
> Hi Matthias,
> 
> On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer
> <matthias.schiffer@ew.tq-group.com> wrote:
> 
> > diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > index 9513020ddd1a..7aaae83c1fae 100644
> > --- a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi
> > @@ -20,7 +20,7 @@
> >  &ecspi1 {
> >         pinctrl-names = "default";
> >         pinctrl-0 = <&pinctrl_ecspi1>;
> > -       fsl,spi-num-chipselects = <1>;
> > +       num-cs = <1>;
> 
> You could simply remove fsl,spi-num-chipselects without passing num-
> cs.
> 
> The spi core is able to count the number of chipselects passed via
> cs-gpios in the device tree.

Hmm, unless I'm overlooking something, this is not going to work:

- spi_get_gpio_descs() sets num_chipselect to the maximum of the
num_chipselect set in the driver and the number of cs-gpios

- spi_imx_probe() sets num_chipselect to 3 if not specified in the
device tree

So I think we would end up with 3 instead of 1 chipselect.


Kind regards,
Matthias