Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2721867pxa; Tue, 25 Aug 2020 01:03:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZ8yfV51OWegf30fEpZroSeEx+u9d9tRi0NlwE/EOolLnFc7pOF22aeHOg+GM/+Y9Vb8o3 X-Received: by 2002:aa7:c805:: with SMTP id a5mr1758460edt.60.1598342614928; Tue, 25 Aug 2020 01:03:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598342614; cv=none; d=google.com; s=arc-20160816; b=Fl5wOfIMbNZA8HWn03+9XeYK8SsOiwaEo1hUPN2o3M7HtbnxZZcys6Qx5BNL380igB hjgFawcdtidWXR+OLKAMXo7CVmYY5YPoNrDI3FzjU4vbHZIUmg+v8kcJR/Chf/msJpmK 08fuW4ctS+azJ5KfhdomQN+cgllG0iP+vKl0r6ww4lQ81fudnglQcjzrcfppUP7ePKa6 jrgND8X2R/l14QVZ8CMOGi4ydW3InuGhh2wLVlsH9MUNS8tm+oFksoj/u7y5V69SRxsQ EnkCWnPe9uxlBQngO+lwS6alPs9IYMWT2Qsb8k0kpRIykedEod+Y8I09T4s4D6Whefc7 NELw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=jj1I4qwtVpwUruOriP9eUnDSP8i372sUHdhXi3LhNpc=; b=EU7fgYpqeJSoOjmrK0yVxXD4E5eNb7/Ln7BBmkQLtX6wheuBaFI6Z4tyARAM5f6jn/ X6a0U0syvTmi6o/Zywil7VSoU8QarEvHdFLUTjJqm7XKgzYsj/elQsBE+8kjzhs5SKyX 08SazCRk7X1d2+azIxIyuXKcxX7dbM4LDXCGzUBltali/cnZcjIoaZo/hcwafW1Uaiei 7wknjqvYLOvjEzxbhfF3FS6EfiRgUgzoBoOGewVCFy/AOAGJ93vrPBZKi6+0N2MNc5ny AJT6liGDGlpvhhj+3DQpGuo8Bjk/v3uzR7CWOAr7a3VgSc7UIyrRBLc9wW3Yn3lukwZe uSSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si7465744eje.180.2020.08.25.01.03.11; Tue, 25 Aug 2020 01:03:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726000AbgHYIAd (ORCPT + 99 others); Tue, 25 Aug 2020 04:00:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:43794 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbgHYIAd (ORCPT ); Tue, 25 Aug 2020 04:00:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 54FA2AC2F; Tue, 25 Aug 2020 08:01:02 +0000 (UTC) Date: Tue, 25 Aug 2020 10:00:31 +0200 Message-ID: From: Takashi Iwai To: Alex Dewar Cc: adrien.crivelli@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches In-Reply-To: <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com> References: <7210c752-0a1f-3985-91f0-b70facf0293c@gmail.com> <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote: > > My mistake -- I didn't read your changelog properly. Sorry! Would you resubmit the corrected fix patch? Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it. thanks, Takashi > > On 24/08/2020 13:30, Alex Dewar wrote: > > There's a mistake in this. The ID numbers are the wrong way round. > > > > Alex >