Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2744501pxa; Tue, 25 Aug 2020 01:54:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr46hHbxKuCPVcEYmBpSwARFtPCgHo2eKbJKbxeoj3EkD4qHeSiJsVvZ/4VCFYjjn7utWW X-Received: by 2002:a17:906:a085:: with SMTP id q5mr9284016ejy.136.1598345641849; Tue, 25 Aug 2020 01:54:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598345641; cv=none; d=google.com; s=arc-20160816; b=pvbnhPrXNRMKZg/NK/W4AVTXa0c8oVBABkxvQPX3HE1ZpQ8f/NrMCYTCqYtpurfleo jPmfd4D9v1MJmSsAh2kNAFgqPJ6Xr6ifp7koT7ST0P4f0+eCH3R1bb+OVmGfL1tyJPbD P96OquNO8T8Sc5IoieiEG6jcAQxB8tUr1/j2e6fUolmL9gbX/W4B6jPgC3rLthxB7Nu8 XfHKar1JTlaHBHzFjcVrdrdN45FQFXhaHgZ7K0BLJfL/IdUHoRJrQ+oakEB0/kHqSEej ypydK65kpIPLjwBYgmBvykUf/ILYq6SQFmD2On3cCtvqi2eOmqFTZ6UYlYouEjNn3tNJ +uZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jCMEu3LP4rV3TV/crFuaErr1op6MoCd32OJKHJT+1Qc=; b=VEGI9zcNchj26DznSQJTgb+CRmvdg5TLnXo+LstQoUZCmClpJvWc+NlbYe8nisjdX5 aV/nhSxxLe/tI7pMYojHeCpgjI1994cTTkXZ7kqY3v5eP6VbCyx2UE+s8WgVM1iUUd6A Lz5XoVHJW4tK/WP1W0vyLDbGyGspLZY/6JsvxfVNHDZjbUhgKDxQwlwjjsGie3DZY/aS FZHouw6wr/4vMiX/8s3cQ8JIgt2ogwcVSXSa8FPc5NQvES5RJhnKGLw9fzp6JMRd1Jp6 /f96E/2HYzsj9HmufnoG62+PilSsjJnRrNMu2AbQGhrDV3wqKKfr37ddOn76dXNUgRv2 VGsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=T1Crdikh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z12si8616122edk.22.2020.08.25.01.53.37; Tue, 25 Aug 2020 01:54:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=T1Crdikh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728964AbgHYGXl (ORCPT + 99 others); Tue, 25 Aug 2020 02:23:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgHYGXk (ORCPT ); Tue, 25 Aug 2020 02:23:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 583E0C061574; Mon, 24 Aug 2020 23:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jCMEu3LP4rV3TV/crFuaErr1op6MoCd32OJKHJT+1Qc=; b=T1CrdikhBaO8D8p7db1LXHq4Kb pLs2oB4WAasNRgSBnXX6PHevM0stlTFMilnwYhyG6DiBix0cL18Nbx/HJsNv2GcI83lrO+AJ5E4TK P0J3/fhCj7dzeaa8TB78fymcDtekIeFPk453VQMnpMRjpbhQbVwwQy9PimVIhMtmQ1FbYlnR2b9/L Py97CNxIf4BhXWjaCMPloR4OKm4Hnntb9HQ1phWDfOAlOtp8GnyqlzciiJziutmC5c9SuzeX6x5be 6prIKshVHSgGdu1unr6XZLY1CikYfrrrj/RTuwfr/YlciYR0It4+bjT06NojWINuT7zA7DGehbzOL GLiWnAsQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASMa-0007NM-7H; Tue, 25 Aug 2020 06:23:20 +0000 Date: Tue, 25 Aug 2020 07:23:20 +0100 From: Christoph Hellwig To: Kai-Heng Feng Cc: bhelgaas@google.com, jonathan.derrick@intel.com, Mario.Limonciello@dell.com, Heiner Kallweit , Mika Westerberg , "Rafael J. Wysocki" , Xiongfeng Wang , Krzysztof Wilczynski , "open list:PCI SUBSYSTEM" , open list , Dan Williams , "Huffman, Amber" Subject: Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain Message-ID: <20200825062320.GA27116@infradead.org> References: <20200821123222.32093-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821123222.32093-1-kai.heng.feng@canonical.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > New Intel laptops with VMD cannot reach deeper power saving state, > renders very short battery time. So what about just disabling VMD given how bloody pointless it is? Hasn't anyone learned from the AHCI remapping debacle? I'm really pissed at all this pointless crap intel comes up with just to make life hard for absolutely no gain. Is it so hard to just leave a NVMe device as a standard NVMe device instead of f*^&ing everything up in the chipset to make OS support a pain and I/O slower than by doing nothing?