Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Aug 2020 16:46:59 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Sanjay R Mehta <sanmehta@amd.com>
Cc:     Sanjay R Mehta <Sanju.Mehta@amd.com>, gregkh@linuxfoundation.org,
        dan.j.williams@intel.com, Thomas.Lendacky@amd.com,
        Shyam-sundar.S-k@amd.com, Nehal-bakulchandra.Shah@amd.com,
        robh@kernel.org, mchehab+samsung@kernel.org, davem@davemloft.net,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD
 PTDMA controller
Message-ID: <20200825111659.GM2639@vkoul-mobl>
References: <1592356288-42064-1-git-send-email-Sanju.Mehta@amd.com>
 <1592356288-42064-2-git-send-email-Sanju.Mehta@amd.com>
 <20200703071841.GJ273932@vkoul-mobl>
 <19b20b55-0748-fb3c-755d-87ee6bdccf48@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <19b20b55-0748-fb3c-755d-87ee6bdccf48@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24-08-20, 13:11, Sanjay R Mehta wrote:
> Apologies for my delayed response.
> 
> On 7/3/2020 12:48 PM, Vinod Koul wrote:
> > [CAUTION: External Email]
> > 
> > On 16-06-20, 20:11, Sanjay R Mehta wrote:
> > 
> >> +static int pt_core_execute_cmd(struct ptdma_desc *desc,
> >> +                            struct pt_cmd_queue *cmd_q)
> >> +{
> >> +     __le32 *mp;
> >> +     u32 *dp;
> >> +     u32 tail;
> >> +     int     i;
> > 
> > no tabs, spaces pls
> Sure, will fix in the next version of patch.

Also, please make sure you run checkpatch.pl with --strict option, that
will help out reducing the churn here

Thanks
-- 
~Vinod