Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Tcg9Wymp2JnI650b5dnnR6FrzffqkYvu23e63JurTaGMX+Ma+MAzOQ8RhZGyznrZPMS8sLqsJ+
 1qTN32yH/cHw==
IronPort-SDR: GS0E3cOxlhtrlTsQ2dLkSpVEMRWywSWViLPNUSZmA5W3Yl0Pw2C5TQe485QFLTDdNCb/enzuyp
 J/Jj/GOTt17A==
Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com
Subject: Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel
 LGM SoC
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
        vijaikumar.kanagarajan@gmail.com, myungjoo.ham@samsung.com,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com, yin1.li@intel.com
References: <20200825083147.25270-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200825083147.25270-2-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200825084053.GA13905@kozik-lap>
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Message-ID: <4cdc6be5-9bd7-3e90-547a-1fe8399c8852@linux.intel.com>
Date:   Tue, 25 Aug 2020 17:16:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200825084053.GA13905@kozik-lap>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

    Thank you for the review comments...

On 25/8/2020 4:40 pm, Krzysztof Kozlowski wrote:
> On Tue, Aug 25, 2020 at 04:31:47PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add usb-typec detection support for Intel LGM SoC based
>> boards.
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>>   drivers/extcon/extcon-ptn5150.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>> index 8ba706fad887..60355a1b5cb2 100644
>> --- a/drivers/extcon/extcon-ptn5150.c
>> +++ b/drivers/extcon/extcon-ptn5150.c
>> @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>>   		return ret;
>>   	}
>>   
>> +	extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>> +				       EXTCON_PROP_USB_TYPEC_POLARITY);
> 
> Hi,
> 
> I think you need the same for EXTCON_USB.
> 
> Although extcon_set_property_capability() error should not be fatal, but
> printing a warn message would be useful.
Yes , earlier we had like below settings in our patches,
+       extcon_set_property_capability(info->edev, EXTCON_USB,
+                                      EXTCON_PROP_USB_VBUS);
+       extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+                                      EXTCON_PROP_USB_VBUS);
+       extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+                                      EXTCON_PROP_USB_TYPEC_POLARITY);

sure, will add warn message as well.

Thanks!
Best Regards
Vadivel
> 
> Best regards,
> Krzysztof
> 
> 
>>   	/* Initialize PTN5150 device and print vendor id and version id */
>>   	ret = ptn5150_init_dev_type(info);
>>   	if (ret)
>> -- 
>> 2.11.0
>>