Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2851641pxa; Tue, 25 Aug 2020 05:16:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7kiXywB8uwBvbN7B7/+ANe1r34Gar8UwOA7okOuT2FQDUZDxPW0+QNY/CXe8z1J1lfZ4a X-Received: by 2002:a17:906:5452:: with SMTP id d18mr10572299ejp.163.1598357807718; Tue, 25 Aug 2020 05:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598357807; cv=none; d=google.com; s=arc-20160816; b=pJBPfzn2rwJ4cpBjH//XzfGD4EhUx5IbpCFPUaZYdV3/8iit+x4/U+lPtQEqTq4xcd GvMRz0CE+m1CJrL+YK6yw/uoewCYWIEz/+SkzpHW/7OY9iTxP4gu3t/sQHKaHrjXlpI4 iABqMGbkm2KiTA5J/Q/obtzFMml/9ifi6K2vYKYlEALgreUHHwBswRmmL+mV017MXD/g /vK4FN/xKcFGg3aaW/ug3O9wv1svxeyh1b6PpD9PvVJP5Dk6z8H3XYjuBimCZKkXrZ7K GnVNd/yFxRJc8mtOj70EDyGujXDiGZ3+lCX0oC44LjdnWq2W4WOCE9IdcD/1al0n1SDf oJ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=XXBH4sOkqPl9zJcXTUASMt/Fu8TtonsFgui8Kl7kFVY=; b=dsbrBVZFWoLKxzKaLwArPb/iv2CMXg8QnsQoghx2xjZyuaKH2aBPdG89iXm7CJ9FEH GM689r96pm4DeqZosp3oP0H/q1jr7ttvsZiK1hdZ2g1/zaUvHjvyEA/Dnb62Hu1jA2Rs I2NeAPVAIu5faMxuCmJg+CoJLb9PA1Q9y7WRR2d1MaE6S1tV3p9p7IRwTBBSttjGT4D9 mOSk8r+P+vjrr/urHDcG1m6uv1EQ135LrlcWHDPd6hTSy/S3f+ptCd8za5kbit9Fjmt/ 1CU1euqaFS4fuMLbNa2RnwYYLQy4yXGAjVoUM0nJyzGj9KF6u2/zQaFcTjyjxCwBZI/9 vraQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TWYP0KD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si7995406eja.95.2020.08.25.05.16.24; Tue, 25 Aug 2020 05:16:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TWYP0KD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729075AbgHYJ0V (ORCPT + 99 others); Tue, 25 Aug 2020 05:26:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbgHYJ0R (ORCPT ); Tue, 25 Aug 2020 05:26:17 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8645C061755 for ; Tue, 25 Aug 2020 02:26:16 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id u131so3398829vsu.11 for ; Tue, 25 Aug 2020 02:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XXBH4sOkqPl9zJcXTUASMt/Fu8TtonsFgui8Kl7kFVY=; b=TWYP0KD8mtsXXsDXuppZAwQQ67rPdc4tICCU7GvKYEWHxBchEiOadVBDgc3Z8BF4XO jgTMzMeNoBBJVXZQfk3AMdbGvkgTBbqlpoiA7C9nNtGeaBxLnx3jEK/vv9nFlnPh9/DJ TgJ990nDyVQNC1Kk3CDHNeM0HolTeK2JGc+JeKc0Asg0tf53T/j0z1oYXEUe3TmHHahK DMXwFbejlBBLFqp1266S1YpJxC8PokIgG47WLH6Q6IrqGhqIXC4/t/ES0j/TyzAtHMVh qHLuYP8F/xPcgPYas5khMHfmzHbhhXfPMw8lKgklue4eg9EkJZXUlSnL6zfYM93OJ86S K39Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XXBH4sOkqPl9zJcXTUASMt/Fu8TtonsFgui8Kl7kFVY=; b=X81zL8HFa1VwnnAD9n2VXXHEqLdQdqO4k3ni4GjiP4oRue6AVKqiVlyN7zk4w0sraH U3QSVyl9y5iL6Ley0YnLXRbFxrVqJJg2a6A9FnDNeL3xmVDytqtsD0ecYbRqSpwPdUSt UrkrEH1pO+24AL7RG777gAPdIVYfZ98iA8USlf36DfKyeHHntR4mKsMJtz5CnYheHnpB Fwk5gvRvQqmTsTgEOFrY2p0bGd1HzsowFnqvnIVFxu/XS2aP6rI6S7avKSS8StvgJy7M uJuWAhDryNpTh21MCHcmff6D7tcZqGltXM+pBYyWdwdkbD5FXVyewHTSPk1BxXC00apN ek3Q== X-Gm-Message-State: AOAM532Ni1+4VDlQ4uQGWlZcLkig17sHaiHpAxWyL/qdo4PkDidaFB5L GSQ1q9o/FON+KMyhnBZc98tPmkjML2P/jAGtmnpVYQ== X-Received: by 2002:a67:8c06:: with SMTP id o6mr5214822vsd.200.1598347574303; Tue, 25 Aug 2020 02:26:14 -0700 (PDT) MIME-Version: 1.0 References: <20200824151035.31093-1-lars.povlsen@microchip.com> <20200824151035.31093-2-lars.povlsen@microchip.com> <20200825084752.GD2389103@piout.net> In-Reply-To: <20200825084752.GD2389103@piout.net> From: Ulf Hansson Date: Tue, 25 Aug 2020 11:25:37 +0200 Message-ID: Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: Add Sparx5 SDHCI controller bindings To: Alexandre Belloni Cc: Lars Povlsen , Adrian Hunter , SoC Team , Rob Herring , Microchip Linux Driver Support , "linux-mmc@vger.kernel.org" , DTML , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Aug 2020 at 10:47, Alexandre Belloni wrote: > > On 25/08/2020 09:33:45+0200, Ulf Hansson wrote: > > On Mon, 24 Aug 2020 at 17:10, Lars Povlsen wrote: > > > > > > The Sparx5 SDHCI controller is based on the Designware controller IP. > > > > > > Signed-off-by: Lars Povlsen > > > --- > > > .../mmc/microchip,dw-sparx5-sdhci.yaml | 65 +++++++++++++++++++ > > > 1 file changed, 65 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml b/Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml > > > new file mode 100644 > > > index 0000000000000..55883290543b9 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml > > > @@ -0,0 +1,65 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mmc/microchip,dw-sparx5-sdhci.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Microchip Sparx5 Mobile Storage Host Controller Binding > > > + > > > +allOf: > > > + - $ref: "mmc-controller.yaml" > > > + > > > +maintainers: > > > + - Lars Povlsen > > > + > > > +# Everything else is described in the common file > > > +properties: > > > + compatible: > > > + const: microchip,dw-sparx5-sdhci > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 1 > > > + description: > > > + Handle to "core" clock for the sdhci controller. > > > + > > > + clock-names: > > > + items: > > > + - const: core > > > + > > > + microchip,clock-delay: > > > + description: Delay clock to card to meet setup time requirements. > > > + Each step increase by 1.25ns. > > > + $ref: "/schemas/types.yaml#/definitions/uint32" > > > + minimum: 1 > > > + maximum: 15 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - interrupts > > > + - clocks > > > + - clock-names > > > + > > > +examples: > > > + - | > > > + #include > > > + #include > > > + sdhci0: mmc@600800000 { > > > > Nitpick: > > > > I think we should use solely "mmc[n]" here. So: > > > > mmc0@600800000 { > > > > Please update patch3/3 accordingly as well. > > This is not what the devicetree specification says. 2.2.2 says that the > generic name is mmc, not mmc[n]. Since there is a proper unit-address, I > don't see the need for an index here. You are absolutely right, thanks! My apologies for the noise! > > > > > > + compatible = "microchip,dw-sparx5-sdhci"; > > > + reg = <0x00800000 0x1000>; > > > + pinctrl-0 = <&emmc_pins>; > > > + pinctrl-names = "default"; > > > + clocks = <&clks CLK_ID_AUX1>; > > > + clock-names = "core"; > > > + assigned-clocks = <&clks CLK_ID_AUX1>; > > > + assigned-clock-rates = <800000000>; > > > + interrupts = ; > > > + bus-width = <8>; > > > + microchip,clock-delay = <10>; > > > + }; Kind regards Uffe