Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Aug 2020 11:55:13 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        linux-actions@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 3/6] regulator: Add regulator driver for ATC260x PMICs
Message-ID: <20200825105513.GE5379@sirena.org.uk>
References: <cover.1598043782.git.cristian.ciocaltea@gmail.com>
 <8da70f0b19de17fb8edead7ff06461ae2451b0e9.1598043782.git.cristian.ciocaltea@gmail.com>
 <20200824110045.GA4676@sirena.org.uk>
 <20200824232310.GA2301286@BV030612LT>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="J4XPiPrVK1ev6Sgr"
Content-Disposition: inline
In-Reply-To: <20200824232310.GA2301286@BV030612LT>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--J4XPiPrVK1ev6Sgr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 25, 2020 at 02:23:10AM +0300, Cristian Ciocaltea wrote:
> On Mon, Aug 24, 2020 at 12:00:45PM +0100, Mark Brown wrote:

> > Please write normal conditional statements to make things easier to
> > read.  It also looks like this would be more robustly written by just
> > having separate ops for DCDCs and LDOs, this could easily break if
> > another device is supported in the driver.

> Sure, I can provide separate ops, but in this case we duplicate almost
> all of them. If this is not acceptable, then I will just rewrite the
> conditional statement.

That's fine, it's just a fairly small struct that's being duplicated not
code.

--J4XPiPrVK1ev6Sgr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9E7hEACgkQJNaLcl1U
h9Df2wgAhaKs443tKsiDZZ8WadCi+JBgtmmpe6/05aaejbq3Nn4RXhrEDvX/T65I
SNnwAjQuMoWveIJyW/e/Cw5/M9E+0pE55HJ6XG8yXvSs6nnd8XNgNwqQNIz7EC5s
qRMoneTdQLpF1ehrgf8zzuvEtwTK9nQ0EfGam7Hy0kLjJgTU+cRziiXnj8sWN8Hm
t6DbJYJwoS5fP1dBZ6OHeaPVW4ke8ioc5KFXkJasHPdyuMuwzsOHQ79zA4DqT9tz
tBlPp+S74k8jiPPO88gr88Zyfy2THWdJgzzaJtgM4Qxne8XKlFrADDzLOohfsi7i
7MQ6Z6DdX9PLBC3CA7miaoTjus/FFQ==
=ZIz+
-----END PGP SIGNATURE-----

--J4XPiPrVK1ev6Sgr--