Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: l4Vuf8WTzX9BgJf23Fn9jXkHwyuqj30PyE4qjAY+TlCPBQUvILt43cbreN2GTOsCn3quVNVwCG
 br/BPtKLP9o41EXJrGEvPBAJf8c9k9/1+ykxc0h7Q5f6tCGcgmtx4Hm1DlFzIBl92r3lyrHRJ8
 b0v+JgLeUkrjaNlJXUwo1j0O4PnAlU00awgvxmBPyYjNa4FJXZcsajHRapjtomFr/Ak3X3DEzy
 9cel1uGAQS/NwT2gEucRtB6qHABOQA2ai/X4yR0VwNRRwqQCA6Ma8ss1qNpz//fNBs90SYBc4Y
 bjQ=
IronPort-SDR: Nd1N5rubAGnAH8MP8Ey/6MF4/cj4EQqY967yrHgvky6U1P5ZlW6WWTvT9Jzqs5IpunIXH9MVxr
 9k//jsnpzPGH2V/2CsiUIZs+DtTyCzqpkVEd02gxFi6Vj7W9chE4kTPsooTmap5OVHraGd34yf
 NT0KRMBAJlQ4UWQA7qaFXeoTNkHIASLkMcH0aeGcTxYHwVrdRIjnsHbPSV22qdXRtsjsalWp/2
 545IEs3EcafVaI6JJsyp4cmOofyRrXlO0z8AgPq83OKliiDVlBX8ZEqRMBdnECh4D377Pxhk9m
 2rM=
Message-ID: <50b5b51e31d9497dbb84c52e11d0d1547d4804f4.camel@ew.tq-group.com>
Subject: Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via
 device tree alias
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Sascha Hauer <s.hauer@pengutronix.de>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Tue, 25 Aug 2020 13:24:10 +0200
In-Reply-To: <548605506aa2e73afafdc228263da04585871e0b.camel@ew.tq-group.com>
References: <20200820075949.19133-1-matthias.schiffer@ew.tq-group.com>
         <CAPDyKFoi7KghuBqu7YVS4GH4Bp1puhgb=PcwBVDvaTesLujrrw@mail.gmail.com>
         <548605506aa2e73afafdc228263da04585871e0b.camel@ew.tq-group.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote:
> On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote:
> > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer
> > <matthias.schiffer@ew.tq-group.com> wrote:
> > > +
> > > +static void __init mmc_of_reserve_idx(void)
> > > +{
> > > +       int max;
> > > +
> > > +       max = of_alias_get_highest_id("mmc");
> > 
> > Is calling of_alias_get_highest_id("mmc") costly from an execution
> > point of view?
> > 
> > If not, we might as well call it directly from mmc_alloc_host()
> > each
> > time a host is allocated instead, to simplify the code a bit.
> 
> It's not particularly costly (it just walks the list of aliases once
> and does a string comparison for each entry), but it does so while
> holding the of_mutex.
> 
> Both variants exist in the current kernel: The I2C core stores the
> hightest index in a global variable, while of_alias_get_highest_id()
> is
> called once for each registered SPI controller. I have a slight
> preference for the global variable solution.

Looking at this again, it's pretty much the same as of_alias_get_id().
I'll remove the extra functions and global variable.

Kind regards,
Matthias