Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Aug 2020 18:55:36 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?S8OpdmluIEwnaMO0cGl0YWw=?= <kevin.lhopital@bootlin.com>
Cc:     linux-media@vger.kernel.org, mchehab@kernel.org,
        robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
        yong.deng@magewell.com, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        paul.kocialkowski@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH 1/7] media: sun6i-csi: Fix the bpp for 10-bit bayer
 formats
Message-ID: <20200824165536.u2yzonoskiqu3c5j@gilmour.lan>
References: <20200821145935.20346-1-kevin.lhopital@bootlin.com>
 <20200821145935.20346-2-kevin.lhopital@bootlin.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bfmdwl5kcym7nka4"
Content-Disposition: inline
In-Reply-To: <20200821145935.20346-2-kevin.lhopital@bootlin.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--bfmdwl5kcym7nka4
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 21, 2020 at 04:59:29PM +0200, K=E9vin L'h=F4pital wrote:
> 10-bit bayer formats are aligned to 16 bits in memory, so this is what
> needs to be used as bpp for calculating the size of the buffers to
> allocate.
>=20
> Signed-off-by: K=E9vin L'h=F4pital <kevin.lhopital@bootlin.com>

Generally speaking, you should also explain why it's not an issue for
the callers. Depending on what that function is supposed to be doing
(returning the padded bits or the padded bits per pixel), your patch
could be either right or wrong.

Since all the callers are using it to generate the number of bytes per
line, your patch is indeed correct. But it should be mentionned in the
commit log.

Maxime

--bfmdwl5kcym7nka4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX0PxCAAKCRDj7w1vZxhR
xcvsAQCvN3gtT1RS8+Z8WwFFELIkFm7M6jqWf3Z9ZBbmSc0aVQD/SUIIWtkekTpB
V+AbU7eYR7tD5BwIbp+/2hTXdMfqogM=
=YTpD
-----END PGP SIGNATURE-----

--bfmdwl5kcym7nka4--