Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Aug 2020 17:03:18 +0200
Message-ID: <s5hk0xm4vk9.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Adrien Crivelli <adrien.crivelli@gmail.com>
Cc:     Alex Dewar <alex.dewar90@gmail.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches
In-Reply-To: <CACjDtnKEGf_z3_wvP5Y_55UgqdPuNRWtONefBXtg0tq7f=ArxQ@mail.gmail.com>
References: <7210c752-0a1f-3985-91f0-b70facf0293c@gmail.com>
        <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com>
        <s5h7dtn6tpc.wl-tiwai@suse.de>
        <CACjDtnKEGf_z3_wvP5Y_55UgqdPuNRWtONefBXtg0tq7f=ArxQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 25 Aug 2020 16:36:13 +0200,
Adrien Crivelli wrote:
> 
> [1  <text/plain; UTF-8 (7bit)>]
> 
> I believe the code is correct (even though the diff is confusing), but I can
> edit the commit message to also mention the model name.
> 
> Should I submit the patch here as a reply ? or should I create a brand new
> submission in a new thread ?

In a new thread please.


thanks,

Takashi

> 
> On Tue, 25 Aug 2020 at 17:00, Takashi Iwai <tiwai@suse.de> wrote:
> 
>     On Mon, 24 Aug 2020 14:31:17 +0200,
>     Alex Dewar wrote:
>     >
>     > My mistake -- I didn't read your changelog properly. Sorry!
>    
>     Would you resubmit the corrected fix patch?
>    
>     Also, better to indicate the device id number in the patch
>     description.  It's confusing which entry you've corrected
>     intentionally for what, and documenting it would help understanding
>     it.
> 
>     thanks,
>    
>     Takashi
>    
>     >
>     > On 24/08/2020 13:30, Alex Dewar wrote:
>     > > There's a mistake in this. The ID numbers are the wrong way round.
>     > >
>     > > Alex
>     >
> 
>