Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2993825pxa;
        Tue, 25 Aug 2020 08:38:52 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx6qF3purzB5L4gWOk2zhEt57ELLxTeqHRXiYAvXM1OIC7vmMsIvUVOV6iRQKqIWh1PrnnJ
X-Received: by 2002:a05:6402:1f0:: with SMTP id i16mr10578793edy.309.1598369932030;
        Tue, 25 Aug 2020 08:38:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598369932; cv=none;
        d=google.com; s=arc-20160816;
        b=KHSdhnLClx5Jje2QKjG1KmGdJ+8dy4/0KqoxbtmD4fiwnJGHtUGH0WmYJzkmRq2LKx
         VcSYwn5EXfSvvh+xlZnkE2L9oXNq+35BMO4lBA+V3HxbYbde5iieNevwytKZfYKGGvpb
         l0FgQlpDKVNyulOgnwT7EzA7NANGk3tbcClSw8eDmYmJaBrsk6BMS5an4Wq3BwYXIEkk
         zsw6/SDmEk5CGm18zUkLEja8ah/+ShmolKWnviFLnsEd0wgwK+cgeqYttROcR9thGrLI
         vRxruOFyJwwh7lQa0O8Py8pqJA1E0dWRy1KLY+M7iWqUDrySa2Y+EF2fWDlw+gYMd9gc
         elhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :ironport-sdr:ironport-sdr;
        bh=qzglwI40AzGMojoH/EkfaDaRKwcRVYGK4qq5vElvtPo=;
        b=QzLmHyFs+mqYl2rV8eXfpK9UNMIjDG9TtlgigaNH8/ECmGfs1sIf5XvxLEPLfuKqG5
         YzmcrcFJlteXTxCNK2NXsp4Vir4AQOheGBR8egcAzFfeVxVCyHtiIeFvtYk0ptSX98N9
         zpzOUnevHkujG6PNv8eQYsDr0i2MJoRZP+aecyaJWQeESKWNOtkRLlTEX/4hH+zNB2ie
         p4lRLuFZTXZQoO5f/6oTxqtQKzBEBIYaDOohspMs0SvIQussoLuZhNZt0I/aayWIOqsA
         XrWZXQuxdlYAcxgckTih23lmU9KlvHgBTEJ0FA796psnJ1bKkF4s8CIfoYAan7tT+mAU
         tmQw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e13si9409673edy.306.2020.08.25.08.38.29;
        Tue, 25 Aug 2020 08:38:52 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726706AbgHYPfG (ORCPT <rfc822;charleyewang@gmail.com>
        + 99 others); Tue, 25 Aug 2020 11:35:06 -0400
Received: from mga04.intel.com ([192.55.52.120]:36602 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726514AbgHYPfF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Aug 2020 11:35:05 -0400
IronPort-SDR: UYvACQJR4YXO4G3L1Cu+3K3ilyJKCSJYHajPEiKpgM3up9xzgTPqTm+NYlx3eFzHDN/YNQDNUr
 s/yqmPZL08pA==
X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="153559431"
X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; 
   d="scan'208";a="153559431"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 08:34:49 -0700
IronPort-SDR: vzkXNWqHEhv+u8xJUKhBznoFEov86BCFyq+MANnIg2WkjyXzZyoTaqIIBur1AYG6N2rzf5JWKf
 OayyfXViTUbw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; 
   d="scan'208";a="328898092"
Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21])
  by orsmga008.jf.intel.com with ESMTP; 25 Aug 2020 08:34:49 -0700
Received: by tassilo.localdomain (Postfix, from userid 1000)
        id 2C1D1301C53; Tue, 25 Aug 2020 08:25:09 -0700 (PDT)
Date:   Tue, 25 Aug 2020 08:25:09 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     mike.kravetz@oracle.com, akpm@linux-foundation.org,
        npiggin@suse.de, agl@us.ibm.com, nacc@us.ibm.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: Fix a race between hugetlb sysctl handlers
Message-ID: <20200825152509.GO1509399@tassilo.jf.intel.com>
References: <20200822095328.61306-1-songmuchun@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200822095328.61306-1-songmuchun@bytedance.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Fixes: e5ff215941d5 ("hugetlb: multiple hstates for multiple page sizes")

I don't think the Fixes line is correct. The original patch
just used a global variable and didn't have this race.
It must have been added later in some other patch that added
hugetlb_sysctl_handler_common.

-Andi