Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2999211pxa; Tue, 25 Aug 2020 08:47:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcEyF2j82PKGzw5TyGSgu+OX3kpIj1yewP7MYNy4H0FkjYrXPMzChgsnXQ8Wd6yYFQNgU9 X-Received: by 2002:a17:906:a3d5:: with SMTP id ca21mr10944197ejb.453.1598370443968; Tue, 25 Aug 2020 08:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598370443; cv=none; d=google.com; s=arc-20160816; b=nSUTeOm0uOpMSSwekcMa6kxlOYaRYGisgzqN+ud/rJWb1TBAyAreR3L30SbxNnVRsW o60Hfsx8xd9284/2uS6Q4dEGvJUXgus+B/xfbvxF34cBqbkpOfWOXnVQ1f/29O47g9fr kQBnwGhgb+iF/HAzJDciqKMqPXWHee3slu8/RS+pBCl90C1vBGjircR1oHN8j/pyBPNz UdMbJ7uTpyWH8FdOspHkQTkibKKALxJUMnRhduJkalupKlu8aRgMP57UnifEuCIpmXMj LmHD4JInn8sQjLxKx2VHRe9NMcJQfLjFrcs7pJ4XD+0LZV0Y6wn3LeVp4gWQm/Iuvk/P Fyhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4G25bF6M9mXNHwMQv9/ooWUHlbj7U1CxxU3WuRplV3I=; b=H3aopKSNNaAW+uN3zeFUQ02O/nzU+VqrmUmdZ0ytnWI1G6k9Qwqahi9MT6qH9dwfWa GC5/uNMx/e9rBBGbpDoePdUjwrFImsUWFAKnuKrgRxzA2fDiCAqFRe1hKLXT12dESiS+ 1JLr2LinqmsZP8QNAfKE/Fv9sr3TI/9/ognKcjnhOJ0Ob+KhRJCFVJ7CNtnGwqcue/Gv mD5rzBMP64MVWy9tLCPB+fx0cod6P0E+PsHafbykDJ9Texepeta847peT0srr2vMeaKw h16pxRdoQyKK3etrXT7C6CsN9+4GJQtkZ3G1VFpxGm43yZr+jw0HLlCVs9dCACtCqO5W 7t5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gG9Tpcop; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si9579656eje.478.2020.08.25.08.47.01; Tue, 25 Aug 2020 08:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gG9Tpcop; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726972AbgHYPpf (ORCPT + 99 others); Tue, 25 Aug 2020 11:45:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:59136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgHYPpc (ORCPT ); Tue, 25 Aug 2020 11:45:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BE0B2067C; Tue, 25 Aug 2020 15:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598370332; bh=J9j8I9e1vUqi85jVzVhKCQp3T2bITZExUCsPWzEeIMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gG9TpcopdDPeldxrfc0Zu7ErcQ5JJWy+leFqtjDc70tZWHAi5s+8DFQXXAsjz773L wERo5NQnTdjXgOQq98zX+bvyzyTHDrzvasAanvQi8RcWgkc+16TbKS44Kgava5ZhPf ZdDKV43+uH7FmJaCWC55FS1sggD3EclaIyA6Urpc= Date: Tue, 25 Aug 2020 17:45:48 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Qu Wenruo , Heikki Krogerus Subject: Re: [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL) Message-ID: <20200825154548.GA1514525@kroah.com> References: <20200803082706.65347-1-andriy.shevchenko@linux.intel.com> <20200803094659.GB635660@kroah.com> <20200825144109.GN1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825144109.GN1891694@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 25, 2020 at 05:41:09PM +0300, Andy Shevchenko wrote: > On Mon, Aug 03, 2020 at 11:46:59AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Aug 03, 2020 at 11:27:06AM +0300, Andy Shevchenko wrote: > > > The commit 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in > > > kobject_cleanup()") inadvertently dropped a possibility to call kobject_del() > > > with NULL pointer. Restore the old behaviour. > > > > > > Fixes: 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in kobject_cleanup()") > > > Reported-by: Qu Wenruo > > > Cc: Heikki Krogerus > > > Signed-off-by: Andy Shevchenko > > > --- > > > v2: replaced ?: with plain conditional (Greg) > > > lib/kobject.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > Thanks, much better, will queue up after -rc1 is out. > > Shouldn't be this taken care of? Yes, will get to it soon, after -rc1 is tough, combined with Plumbers... greg k-h