Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] IMA: Handle early boot data measurement
To:     Mimi Zohar <zohar@linux.ibm.com>, stephen.smalley.work@gmail.com,
        casey@schaufler-ca.com
Cc:     tyhicks@linux.microsoft.com, tusharsu@linux.microsoft.com,
        sashal@kernel.org, jmorris@namei.org,
        linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200821231230.20212-1-nramas@linux.microsoft.com>
 <a7ea2da1f895ee3db4697c00804160acb6db656e.camel@linux.ibm.com>
From:   Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Message-ID: <307617de-b42d-ac52-6e9e-9e0d16bbc20e@linux.microsoft.com>
Date:   Tue, 25 Aug 2020 08:46:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <a7ea2da1f895ee3db4697c00804160acb6db656e.camel@linux.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/25/20 8:40 AM, Mimi Zohar wrote:
> On Fri, 2020-08-21 at 16:12 -0700, Lakshmi Ramasubramanian wrote:
>> The current implementation of early boot measurement in
>> the IMA subsystem is very specific to asymmetric keys. It does not
>> handle early boot measurement of data from other subsystems such as
>> Linux Security Module (LSM), Device-Mapper, etc. As a result data,
>> provided by these subsystems during system boot are not measured by IMA.
>>
>> Update the early boot key measurement to handle any early boot data.
>> Refactor the code from ima_queue_keys.c to a new file ima_queue_data.c.
>> Rename the kernel configuration CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS to
>> CONFIG_IMA_QUEUE_EARLY_BOOT_DATA so it can be used for enabling any
>> early boot data measurement. Since measurement of asymmetric keys is
>> the first consumer of early boot measurement, this kernel configuration
>> is enabled if IMA_MEASURE_ASYMMETRIC_KEYS and SYSTEM_TRUSTED_KEYRING are
>> both enabled.
>>
>> Update the IMA hook ima_measure_critical_data() to utilize early boot
>> measurement support.
> 
> Please limit the changes in this patch to renaming the functions and/or
> files.  For example, adding "measure_payload_hash" should be a separate
> patch, not hidden here.
> 

Thanks for the feedback Mimi.

I'll split this into 2 patches:

PATCH 1: Rename files + rename CONFIG
PATCH 2: Update IMA hook to utilize early boot data measurement.

  -lakshmi