Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3019464pxa; Tue, 25 Aug 2020 09:17:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYna5HFizw8cd7PaGJPflV7UCHIQQln1ca85SQ+mfV48YSDhuHqhB6YlEMCV2xvvtyN29W X-Received: by 2002:a17:907:2717:: with SMTP id w23mr8928130ejk.236.1598372222756; Tue, 25 Aug 2020 09:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598372222; cv=none; d=google.com; s=arc-20160816; b=v0MA0wetdn9XC7kgI+QXnGpzH3Yj8y+/YAWHNHuCNrT9uEIN77f6nQbxbYSJCN/bfm 93bwzXgLf9CiKr9gNZFY9iY0a2iWcxuo2vLHwn+VYnFijthChQgTlfUyIrNm83VFzjS6 EKjx1M7gt2jJJViV1ABvhDWmnZrdFrOyYWLDuUbN6kpB9TcT9+5fG2p4SG/TjCHnXs6O scB/CHiNnuSTRfk7mOwRaK3DwDJzFVocKAah5khWmjA/gHeesDe/Spumvz5rcGWAUBDO EI1dw00gMh2krPtLQTDm/nw1MvV1Xc9lL73kBlzzfdfUOGdizQl+sRKIWIPS/O3MIFVi Byxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=TO0PzOFOyItfLIL4LxWonWda6X9pWm4X8EVRxhn39wo=; b=sgGbbRZtl0XhLMQxhD01OfwBdtdzvcdvba6o0VsCXm13T76ygtJHGvR4eAxgsfdtbm EI+4kjQVkEjjUV/Ry3r3yzN0H6CLI6Ke6c6qgfUETtdamWrRicux+iafk378Tk0ql1/f deLy4AaGPeCJreencZG71bNk+oE2kmVXztckMjanWd0jG7jGjDsr4SH6775HD/Wq+qTD rHfz1qB9QTTa7dZSSr+Rq3k3wS1OX9IvFwY5CmZiNlWOuQTfdaKiQbrhIcRHfvMUX1bc fw7U0Pi6gZ8zCOiEs5BVJxgbCCAu64FfTFZVwr6BJ+96KNaL8yGD0BtS+6wGCVyCh6UB wWcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si9206177edk.48.2020.08.25.09.16.37; Tue, 25 Aug 2020 09:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbgHYQNL (ORCPT + 99 others); Tue, 25 Aug 2020 12:13:11 -0400 Received: from mga02.intel.com ([134.134.136.20]:44149 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbgHYQNF (ORCPT ); Tue, 25 Aug 2020 12:13:05 -0400 IronPort-SDR: 9NIxVUSSNiWyZsVFz/+W3io5YEp74TN/9dLbGB4Ofej96Vx4zm9F8Vn+AgXcliX9AAfMbSxmoW r7GSBlsWtQ4w== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="143919874" X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; d="scan'208";a="143919874" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 09:13:04 -0700 IronPort-SDR: Ayx+5KGXwIMIpz5Ych1zslMFk2ol3MLNgYL8uPEqGYGgeDR4sC9Y44KVhWwFN5Cs3BdUQ4pu4c C7UzGVkTdx+A== X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; d="scan'208";a="499911294" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.213.162.112]) ([10.213.162.112]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 09:13:03 -0700 Subject: Re: [PATCH v11 8/9] x86/vdso: Insert endbr32/endbr64 to vDSO To: Andy Lutomirski Cc: X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , "open list:DOCUMENTATION" , Linux-MM , linux-arch , Linux API , Arnd Bergmann , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang References: <20200825002645.3658-1-yu-cheng.yu@intel.com> <20200825002645.3658-9-yu-cheng.yu@intel.com> From: "Yu, Yu-cheng" Message-ID: Date: Tue, 25 Aug 2020 09:13:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/2020 5:33 PM, Andy Lutomirski wrote: > On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu wrote: >> >> From: "H.J. Lu" >> >> When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be >> called indirectly, and must have ENDBR32 or ENDBR64 as the first >> instruction. The compiler must support -fcf-protection=branch so that it >> can be used to compile vDSO. >> >> Signed-off-by: H.J. Lu >> Signed-off-by: Yu-cheng Yu >> Acked-by: Andy Lutomirski > > I revoke my Ack. Please don't repeat the list of object files. Maybe > add the option to CFL? I will update the patch. Yu-cheng