Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3037254pxa; Tue, 25 Aug 2020 09:44:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4n24nj90qAgrJFZQtCIv8d1NH6o60l71Syz2TscQsxrIwz7kshPUPhG1nJuL99LNtrRGJ X-Received: by 2002:a50:ed88:: with SMTP id h8mr10702285edr.360.1598373871964; Tue, 25 Aug 2020 09:44:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598373871; cv=none; d=google.com; s=arc-20160816; b=LLlfe8DuBRRAiGVW29XlBzZiJfn2j3j1raqHoeieUq9KU3kexmvgiVQidR5ED16y7T VJs4hWbNsWJUbs61gD36op53TMSOdKMN9Ex1QlEK+REr6gusf7hpE3FLp4PNDC+e/4jd j7j6jRnDPEzBeOs8M6gqzLnJkJnRrO2Ctx/9toKmjq1FfPopMURS4MdfBaaNMb6xPovn ZUeZOQNMq1BA5M2g1dC0nCDwjpNQBFYUnUW1Mdp57WJh2avCvqrPzodnmaYY2OC7/bic eZSiiqrhh0qHiRIT0H7LAq7pkFYitEnUTUnmL8XJdF86bfoFC0JufJKvfkhi7Lk5CUFM 9MwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=cOGcQuNcgu27ssRe7+iEilXICwkaDhh0xHUhsfky6/A=; b=nU5IsglJ1/XLh8i/76s0Q/fnDQVxBdZhAbm5XVuNM6zuPOzMSHtcE46m9D/ylZ+OFr 4gzr98zwxjZp+fxGBGxc4NHj4owkj1DKs/m1Yn0XYyuLFF1+rC3l5l2lQt+10u/vPH4K jlonZAruk+pOC00aU4RrccSvcLIj/kXskxyuVr1RiUi1/U76vDlUNLOhe2vwQ1cbvFPy hruhiXFZeKpXiJhfEKeAP4HfJLMkAS7Vk2HFJ7JG5qfsi1R7O7du5On7S/QMbeEMM67v 8dSg5hnF8wpFXiMM5/GQCgVtY8mYlfko1+cINuLzRp3CsVFcBLRq6olxW2ieBEQ1/JMP qCow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=fRFpmnqd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si8905986eja.198.2020.08.25.09.44.06; Tue, 25 Aug 2020 09:44:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=fRFpmnqd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726356AbgHYQnY (ORCPT + 99 others); Tue, 25 Aug 2020 12:43:24 -0400 Received: from gateway34.websitewelcome.com ([192.185.149.13]:40783 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbgHYQnU (ORCPT ); Tue, 25 Aug 2020 12:43:20 -0400 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E69AB86EAB0 for ; Tue, 25 Aug 2020 11:43:17 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Ac2Xk48AtLFNkAc2XkYVEl; Tue, 25 Aug 2020 11:43:17 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cOGcQuNcgu27ssRe7+iEilXICwkaDhh0xHUhsfky6/A=; b=fRFpmnqdD+FV804lUWuyvAZWBn X4dF1aIY3v3YTV0F+UJuTPHXi6WvGPmwCRi4qh4bbjlMcUBZJYX4jJb8tdD+o3m6UWuAe7yo+r5Zs obIUsnhWJ33DeeIc16B9xOVd7ioOInz5s0vcrRCWgrORSU4RWYMowBDr+COgroKxen4E8pNCtmFR5 2n5C5sBchDXyzeAZXXt+Dr1dOuolMFUszSqBrQBOV7+5Hd8V/laHZqXYrvHqEKBfEELVVq+ciHYbJ C93vdYvzgpYMuETgWOp04+omT/m6jjxxSOWPP3FSVWdAmdlTjpFC8TjG9WbXGzChZD2bvtlosLOl8 xC45sjSQ==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:58602 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kAc2X-000vvH-4N; Tue, 25 Aug 2020 11:43:17 -0500 Subject: Re: [PATCH] IB/qib: remove superfluous fallthrough statements To: Joe Perches , Alex Dewar Cc: Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Roland Dreier , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200825155142.349651-1-alex.dewar90@gmail.com> <4877c3a5-365e-4500-43c0-4a4361e2cda3@embeddedor.com> <086ee29ef75f657dcf45e92d4ebfdf2b3f4fcab8.camel@perches.com> From: "Gustavo A. R. Silva" Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzStHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvYXJzQGtlcm5lbC5vcmc+wsGrBBMBCAA+FiEEkmRahXBSurMI g1YvRwW0y0cG2zEFAl6zFvQCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AAIQkQ RwW0y0cG2zEWIQSSZFqFcFK6swiDVi9HBbTLRwbbMZsEEACWjJyXLjtTAF21Vuf1VDoGzitP oE69rq9UhXIGR+e0KACyIFoB9ibG/1j/ESMa0RPSwLpJDLgfvi/I18H/9cKtdo2uz0XNbDT8 i3llIu0b43nzGIDzRudINBXC8Coeob+hrp/MMZueyzt0CUoAnY4XqpHQbQsTfTrpFeHT02Qz ITw6kTSmK7dNbJj2naH2vSrU11qGdU7aFzI7jnVvGgv4NVQLPxm/t4jTG1o+P1Xk4N6vKafP zqzkxj99JrUAPt+LyPS2VpNvmbSNq85PkQ9gpeTHpkio/D9SKsMW62njITPgy6M8TFAmx8JF ZAI6k8l1eU29F274WnlQ6ZokkJoNctwHa+88euWKHWUDolCmQpegJJ8932www83GLn1mdUZn NsymjFSdMWE+y8apWaV9QsDOKWf7pY2uBuE6GMPRhX7e7h5oQwa1lYeO2L9LTDeXkEOJe+hE qQdEEvkC/nok0eoRlBlZh433DQlv4+IvSsfN/uWld2TuQFyjDCLIm1CPRfe7z0TwiCM27F+O lHnUspCFSgpnrxqNH6CM4aj1EF4fEX+ZyknTSrKL9BGZ/qRz7Xe9ikU2/7M1ov6rOXCI4NR9 THsNax6etxCBMzZs2bdMHMcajP5XdRsOIARuN08ytRjDolR2r8SkTN2YMwxodxNWWDC3V8X2 RHZ4UwQw487BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJBH1AAh8tq2ULl 7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0DbnWSOrG7z9H IZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo5NwYiwS0lGis LTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOPotJTApqGBq80 X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfFl5qH5RFY/qVn 3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpDjKxY/HBUSmaE 9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+ezS/pzC/YTzAv CWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQI6Zk91jbx96n rdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqozol6ioMHMb+In rHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcAEQEAAcLBZQQY AQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QSUMebQRFjKavw XB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sdXvUjUocKgUQq 6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4WrZGh/1hAYw4 ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVnimua0OpqRXhC rEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfgfBNOb1p1jVnT 2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF8ieyHVq3qatJ 9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDCORYf5kW61fcr HEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86YJWH93PN+ZUh 6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9ehGZEO3+gCDFmK rjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrSVtSixD1uOgyt AP7RWS474w== Message-ID: Date: Tue, 25 Aug 2020 11:49:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <086ee29ef75f657dcf45e92d4ebfdf2b3f4fcab8.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1kAc2X-000vvH-4N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:58602 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 17 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/25/20 11:26, Joe Perches wrote: > On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: >> >> On 8/25/20 10:51, Alex Dewar wrote: >>> Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") >>> erroneously marked a couple of switch cases as /* FALLTHROUGH */, which >>> were later converted to fallthrough statements by commit df561f6688fe >>> ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity >>> warning about unreachable code. >>> >>> Remove the fallthrough statements and replace the mass of gotos with >>> simple return statements to make the code terser and less bug-prone. >>> >> >> This should be split up into two separate patches: one to address the >> fallthrough markings, and another one for the gotos. > > I don't think it's necessary to break this into multiple patches. > Logical changes in a single patch are just fine, micro patches > aren't that useful. > There is a reason for this. Read the changelog text and review the patch. Thanks -- Gustavo