Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, m.szyprowski@samsung.com,
        b.zolnierkie@samsung.com
Subject: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter
 Driver
Date:   Tue, 25 Aug 2020 19:30:30 +0200
In-Reply-To: <6062dc73-99bc-cde0-26a1-5c40ea1447bd@infradead.org> (Randy
        Dunlap's message of "Tue, 25 Aug 2020 10:19:51 -0700")
Message-ID: <dleftjr1ruvdjd.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <6062dc73-99bc-cde0-26a1-5c40ea1447bd@infradead.org>
        <CGME20200825173041eucas1p29cb450a15648e0ecb1e896fcbe0f9126@eucas1p2.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-08-25 wto 10:19>, when Randy Dunlap wrote:
> On 8/25/20 10:03 AM, =C5=81ukasz Stelmach wrote:
>> diff --git a/drivers/net/ethernet/asix/Kconfig b/drivers/net/ethernet/as=
ix/Kconfig
>> new file mode 100644
>> index 000000000000..4b127a4a659a
>> --- /dev/null
>> +++ b/drivers/net/ethernet/asix/Kconfig
>> @@ -0,0 +1,20 @@
>> +#
>> +# Asix network device configuration
>> +#
>> +
>> +config NET_VENDOR_ASIX
>> +	bool "Asix devices"
>
> Most vendor entries also have:
> 	default y
> so that they will be displayed in the config menu.

OK.

>> +	depends on SPI
>> +	help
>> +	  If you have a network (Ethernet) interface based on a chip from ASIX=
, say Y
>> +
>> +if NET_VENDOR_ASIX
>> +
>> +config SPI_AX88796C
>> +	tristate "Asix AX88796C-SPI support"
>> +	depends on SPI
>
> That line is redundant (but not harmful).

Why? Is it because NET_VENDOR_ASIX depends on SPI? Probably it
shouldn't. Thanks for spotting.

>> +	depends on GPIOLIB
>> +	help
>> +	  Say Y here if you intend to attach a Asix AX88796C as SPI mode
>> +
>> +endif # NET_VENDOR_ASIX

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl9FSrYACgkQsK4enJil
gBAUJAgAoiKqrS1LhZjmIMWJTRRqqtE0F8elsK7QHkVHD5bkYgd/Kr2zmm/wArKS
3wBPj6qCVUBR2rUQR5DvW+rgSxxGu16IxotAQtlN9ljAIR5MxiqjZWdhq0pUuAJq
+3gXhJgjbBK+Wp8uwoVXuwCYvBakcY2g3zoz2cT6GeDc8Tp3yr51yb8tidUNqtyG
rbx55gRcr0MXhT/OU3wkUQnozFKC3pv+sBuwZ75dKzLe2UwJZ1J737Ywm/kLPF0n
5suIPoghPWG/pyLzbw5RfE1AOhEho70XrEuwBG0eh7U8FMAD7zrmhldMjdGSeXDy
FqFEfsirb4xsQs+tktyVKFt9OAIpqA==
=W6/v
-----END PGP SIGNATURE-----
--=-=-=--