Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3118427pxa;
        Tue, 25 Aug 2020 11:56:37 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwlonYRK7ujeJtt9xpdW53vc+RWKDChDrcH038uov2FoQkOdGKCa0BWJY9LzukYk6qtrnNu
X-Received: by 2002:a17:906:3bc1:: with SMTP id v1mr11972012ejf.233.1598381796858;
        Tue, 25 Aug 2020 11:56:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598381796; cv=none;
        d=google.com; s=arc-20160816;
        b=Bjluuo8AgR1MZUCAdeNfZEMV39DYfV3QMVQpQ7Y9GejrQSKMkalmRfOj/BsjcEyY/4
         vxG95DWCXsqEZTeO8DnDSgtRPWyLjBuotAc/NWAsSk0sIx1qugwuqUOVsvRcYWTToVql
         l+cLHCVRxmkYNhPMYwvsLYNilxg09Vxl1TOnqoC6a4lJXKoM5XzLFYdeu3zWbxk/To/w
         /RqpvZakHpAIjEaBpsr4maCVjJIZLi+baOKe2lBC0Q97hqwRT9YxprF0xVfpbfefgJle
         B6flHMwP4O2VNclSoVEkvN7WnqCfM8/sCC/mnjh4mdx+uq9PaBWoyREkFzfnzn20aYPx
         v24w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :ironport-sdr:ironport-sdr;
        bh=a35SruCeSgAf13z3IETM8h32o/J5qEKTv4nZuvfjvkE=;
        b=hPzza6PBTkZTo7WWbr1UrjevNvEXvRr5qF/NMldBq/ZtGPBM64tmzcpa0qoO1hsszU
         Ny3dKljWCQ1g1Z9MWEGoAZzsvmv3foszhMdAf/NQ7yhC267qM4vLjBHPfs3CK26TcaOl
         sgvW8yrs5RhsGo9hNW8OU9HtSkRBLonKyIiY4o31uIgf1rAco3FqMHZlKmXfrFkzSAF1
         BQixIUqZtB5O+v2bvqyUBy81+QDHj71bo8l1jZfgryKaHykPNiDNBAHP/MDev0w5cUzq
         RlaqGV7v0ML7KzcdAGEjfcJdsoBpTqJr+8y5j6S1LO+DthNaqLjoTLG/jN/goSpxIEHR
         C8hQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w13si1721151edt.439.2020.08.25.11.56.13;
        Tue, 25 Aug 2020 11:56:36 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726698AbgHYSx2 (ORCPT <rfc822;charleyewang@gmail.com>
        + 99 others); Tue, 25 Aug 2020 14:53:28 -0400
Received: from mga06.intel.com ([134.134.136.31]:16450 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726391AbgHYSx0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Aug 2020 14:53:26 -0400
IronPort-SDR: +30W4RogLoAFfgJs5u01pbFVs+vbGTlNOPo2T64DRNY9lQHUgE9Eoelhhuynnxs/R5bRhryFdP
 YxPUwcG0ypiw==
X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="217729489"
X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; 
   d="scan'208";a="217729489"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 11:53:23 -0700
IronPort-SDR: 4BHPj+CdBNJj1OcZhZceUOeJli0U4JoHzTZk7WHsBGIRqqnq1oSLDMKa7WRHeL34Q6cIplwAFe
 wgCpOw2SHr9w==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; 
   d="scan'208";a="328960106"
Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21])
  by orsmga008.jf.intel.com with ESMTP; 25 Aug 2020 11:53:23 -0700
Received: by tassilo.localdomain (Postfix, from userid 1000)
        id B3985301C53; Tue, 25 Aug 2020 10:40:43 -0700 (PDT)
Date:   Tue, 25 Aug 2020 10:40:43 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Al Grant <al.grant@foss.arm.com>
Cc:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        acme@redhat.com
Subject: Re: [PATCH] perf: correct SNOOPX field offset
Message-ID: <20200825174043.GQ1509399@tassilo.jf.intel.com>
References: <9974f2d0-bf7f-518e-d9f7-4520e5ff1bb0@foss.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9974f2d0-bf7f-518e-d9f7-4520e5ff1bb0@foss.arm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
> perf_event.h has macros that define the field offsets in the
> data_src bitmask in perf records. The SNOOPX and REMOTE offsets
> were both 37. These are distinct fields, and the bitfield layout
> in perf_mem_data_src confirms that SNOOPX should be at offset 38.

Looks good.

Reviewed-by: Andi Kleen <ak@linux.intel.com>

Probably should have a Fixes: header

-Andi