Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3339009pxa; Tue, 25 Aug 2020 19:28:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+Cdko5wLpwanJSppACS/iX0zqQewQvQ5kGc6mK7v6clMNKdRDDM1EpkO87P723LXyvGmT X-Received: by 2002:a17:906:5206:: with SMTP id g6mr13939945ejm.292.1598408907637; Tue, 25 Aug 2020 19:28:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598408907; cv=none; d=google.com; s=arc-20160816; b=oL69Vzg+MIVaYYkTJHd8BAonJs/HzgJnHDWbXBUSNuhc+hiA6Xy0s8s5LDMgz0Q2hn wx9uPH+JrCZFDAjbXdMnZkqNL3IIjbsTUOenkZ7hp+5PP4bEgS2dK8IFw4uOmpncPqWf BzdbHt+CZJ5vwXp6/UMFvJdiIAofRt/7ALUECZskgzYDnwC5+Sxmhds0PosALQTe6V4Z eyPdpv40oeXsb0AkuGrZy/3aMmMeIUEb14Cmo4lXZF1Htu4fPhVGkUov/Y1E8e+AAY3C txz/Pqse4IhsFzZH8+HM7LCJyAVgtU/L8is6N2GW9Od3rrdbfPoKZt5tuA5+D5U6Tnep A4gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sxFvO/GLCLgBRfmkOAspDUyP4lpcTibuAN2MiSmiuaE=; b=YXzeZJaTIKA59yTGAaFG+1heP+lxYe+WhBUnfwc/6ms0BbyvTkdXIgtuXesCAVqDB+ O9/4p99EAnnrUyUcUIBbaslz6h3iuUdeOYPimUJPc7n7vHeX+UjgT65lpXl+9hO88nf5 P1ePt7ltDYBD1DS52YMYzVNP8bNMpyhpHP6BHyPYFH+vcxReLGrFvRZpRTM9ISjR7JgX wfoGXKkYGLWbN9pL38vh5FOc5lq3lj64vzil3cxQJst6DWhsUF8Zfs9UP+1kfLZk/5Ky GM5X4MNYbx1xMYC56JcigX4/AUOlg1ANSRTJlwGv/TbxhcT+zIXIxrJNcwOLKq//NLhs RMtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=ncJE4xT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x33si526031edc.298.2020.08.25.19.28.03; Tue, 25 Aug 2020 19:28:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=ncJE4xT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbgHZC00 (ORCPT + 99 others); Tue, 25 Aug 2020 22:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726627AbgHZC00 (ORCPT ); Tue, 25 Aug 2020 22:26:26 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEC55C061574; Tue, 25 Aug 2020 19:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sxFvO/GLCLgBRfmkOAspDUyP4lpcTibuAN2MiSmiuaE=; b=ncJE4xT0RV0DL88DyjXY0ZZWNX c5H0dGv17CatAlJxzga6RRk56Q8fwDpXIuW7EEgf7tICAzbPlgtNvK36sFxtwQvfroJ8qKcfn9ct+ v4xOejFU30Eo6Um3PIONALTAT6Ii6GySy9Kynet63yIETPr4X7Oj3m9vt0bUhKXato+jPPJgzIcmN xCRFwAEBsbxCuWcC3955WsJF+6u+RN5YmHIZREM7WnjcBaZxITdzSi1qvAFtPV8idzN0tt+oTQK6S sSkJThXGSEmeNs+teYiAx47mwssooc7xfO79kmW10tUeb6CG3YyCKJVsgR67CM/sfzG2kQmIpROjy HXDE9yLQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAl8p-0003AS-OR; Wed, 26 Aug 2020 02:26:23 +0000 Date: Wed, 26 Aug 2020 03:26:23 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] iomap: Support arbitrarily many blocks per page Message-ID: <20200826022623.GQ17456@casper.infradead.org> References: <20200824145511.10500-1-willy@infradead.org> <20200824145511.10500-6-willy@infradead.org> <20200825210203.GJ6096@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825210203.GJ6096@magnolia> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 25, 2020 at 02:02:03PM -0700, Darrick J. Wong wrote: > > /* > > - * Structure allocated for each page when block size < PAGE_SIZE to track > > + * Structure allocated for each page when block size < page size to track > > * sub-page uptodate status and I/O completions. > > "for each regular page or head page of a huge page"? Or whatever we're > calling them nowadays? Well, that's what I'm calling a "page" ;-) How about "for each page or THP"? The fact that it's stored in the head page is incidental -- it's allocated for the THP.