Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3373964pxa; Tue, 25 Aug 2020 20:57:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/O74u6oU/JKpsHN28JF8NxPpwx5PpQEUMIwEDDGACYXefZ4hVTQBBd372WHI2edjtrpvs X-Received: by 2002:a50:a0c7:: with SMTP id 65mr12872071edo.375.1598414233143; Tue, 25 Aug 2020 20:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598414233; cv=none; d=google.com; s=arc-20160816; b=S9Wj5nATP65aqhdjU5B3f5K7Pet7wYRoAb2sjHT0jIhIgUW/eIUAFGQCocAukYAKGV riwsuJZfRWarDfK7NUCoMqcA/+y67LpQRrJBHcrl+LFkz5GzCRkCpJojVDB3tvQI8jgZ wmB3M5J4E0/TCzkmyFNS9iN9RgAr8FemfYAnIzYeA4aNOpMNPXtq5FRB5qHGxmCKsNGh TmwLqj7UMy8BNBOQBwqxohB7cLj88TzoA2dlImW+d0BVY7yLoV1ah/wKWEFQxz9/OE3p 6krzEC714lbgJgdXswgAm/leOEZt7K0C41iZdLHhE4H/fyc4vJRNAyYeUnmxu+ibc9nD QjTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=8kAaY6c3Ie274emxtC6FZHd309aQbc2d32PZCmT+tsg=; b=DRhkTCN4lL4sMstFI2bOfWOSzT8dwVlkSLf34yWCYKYuqlHT0AnO/LUBxQnk83nApv fk8wDNWoubiEz0A6+5tHUzH/CCWHJeYoqg8yDG+7CVtJYsEKlht9378c8M/jt+w2ruWN WIfi9SZR6q/XpZNn+kWJWKULDKYbCk5LlKMg8LTjaXjqSpw9aO566mWbl4QwFrBzl1oz mrsKtarQ9PZpmsNysyBtc54RQ9mq5rLAgZJO0HOg99YhlTC2QGWC+5pgoNcz0hn7dEjy 4Su8wopEHaeiAXLu22ndBX8DumlDujJuSXWvlbhtRdjyDcNPTcp279AsK/Cr52OLwV7i P4vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si742628eji.611.2020.08.25.20.56.50; Tue, 25 Aug 2020 20:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726718AbgHZDxf (ORCPT + 99 others); Tue, 25 Aug 2020 23:53:35 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:49356 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726682AbgHZDxf (ORCPT ); Tue, 25 Aug 2020 23:53:35 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DF2ABB4A2B30A12DD9EB; Wed, 26 Aug 2020 11:53:32 +0800 (CST) Received: from localhost (10.174.179.108) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 26 Aug 2020 11:53:26 +0800 From: YueHaibing To: , , , , , , CC: , , YueHaibing Subject: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero Date: Wed, 26 Aug 2020 11:53:21 +0800 Message-ID: <20200826035321.18620-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq should be int type. Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR") Signed-off-by: YueHaibing --- drivers/irqchip/irq-ti-sci-intr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c index cbc1758228d9..85a72b56177c 100644 --- a/drivers/irqchip/irq-ti-sci-intr.c +++ b/drivers/irqchip/irq-ti-sci-intr.c @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain, struct ti_sci_intr_irq_domain *intr = domain->host_data; struct device_node *parent_node; struct irq_fwspec fwspec; - u16 out_irq, p_hwirq; - int err = 0; + int p_hwirq, err = 0; + u16 out_irq; out_irq = ti_sci_get_free_resource(intr->out_irqs); if (out_irq == TI_SCI_RESOURCE_NULL) -- 2.20.1