Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3455389pxa; Wed, 26 Aug 2020 00:17:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDvMXp5Il3wuo5L/UhL6hmAk0TA5K3qZvXJOa6r+ij+dcWtPsMnFRlGPaP68bviyX3wexB X-Received: by 2002:a17:906:3f91:: with SMTP id b17mr13550798ejj.165.1598426235643; Wed, 26 Aug 2020 00:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598426235; cv=none; d=google.com; s=arc-20160816; b=VwY/W+S8xVm+pNjEDYl8KzZ8e3lrNTC0gNaHgE0gGPmNDhUr+U4HhR3SZgVlz0ZNnK l2kMfuid1Y/CUWzpxK8Zep80FSTYnmblfmuWEI33An8o6zabiELTuRBApvNwU6S3bmb8 UCcvRbyWRANxoA4phAcQeylv6NTaTu/2dugPpAC8FK+ZjqmUAFdUEPsGKzCO0iK6QiCb lWe3NChMEUf7+/BOa1h1vKV353Af4KEdzTGnFptKzyaX/E2ww5a2cZ2UeSVBvHl8sZkB ZryGaCPWW6XoY2Dlib5DAvjGYVJx6uGCTq9gxwHu0+/n4zXnlwjZW3RsEY/olxI3sIqT nA4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:organization :subject:cc:to:from:dkim-signature; bh=JSuM4dKUM2nfywxTFJ0hWSXUwcdiL5ludU2CopjahqY=; b=NC9EQlXM9g2rZVURk/bvEi0VTL3n30oxGt9Vu7PkzER1Yv4jFeQlWKmxjpWIvj8iVg t0M9TQcVbHWCWBpmxKI2Y+wGwEi8o+AEPyo7Ln9aV820jq/dYTRqZRTb9Axs9dIwVvwo hC5YWATxstRbds8I9rm+zzYhjeC2UI8U9VcNvlgUS1PL3Y0tV6Yc2AJqG+T9NDfu/tj1 FWMO/d5mJ4jy4i9jPtAGXeiDdOezZDgDwaADmFuFXprUbnUj72pGckluU4CwWzQHyBIJ Lsk+rCXGSH/zJ8UXH3AXNaMfosJKjXFJ/avS+PvuXFTmFOmcCQq0TMW70nmSWF+ZzQ6+ bp7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=eUJFmJDS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc14si1010688ejb.714.2020.08.26.00.16.53; Wed, 26 Aug 2020 00:17:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=eUJFmJDS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726719AbgHZHQP (ORCPT + 99 others); Wed, 26 Aug 2020 03:16:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbgHZHQP (ORCPT ); Wed, 26 Aug 2020 03:16:15 -0400 X-Greylist: delayed 744 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 26 Aug 2020 00:16:15 PDT Received: from canardo.mork.no (canardo.mork.no [IPv6:2001:4641::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B269C061574 for ; Wed, 26 Aug 2020 00:16:14 -0700 (PDT) Received: from miraculix.mork.no (miraculix.mork.no [IPv6:2001:4641:0:2:7627:374e:db74:e353]) (authenticated bits=0) by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id 07Q73N8G024392 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 26 Aug 2020 09:03:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1598425404; bh=JSuM4dKUM2nfywxTFJ0hWSXUwcdiL5ludU2CopjahqY=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=eUJFmJDSPFK1jgdbN2iYYyLcENd+E373WgO9hlVhHhEsORapOdeEamKR3VaMY2siS HyLzxCYK53OT5U+fMuRBBrChG8rEwz+Q5s3cOPgkW+esFa+ViA5bHdbZnULxuXh4aa hivXqjsBwKJXqBHICDBq6Bsbwk5mtmXarUugplrM= Received: from bjorn by miraculix.mork.no with local (Exim 4.94) (envelope-from ) id 1kApSt-0001tZ-4K; Wed, 26 Aug 2020 09:03:23 +0200 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: YueHaibing Cc: , , , , , , Subject: Re: [PATCH] net: cdc_ncm: Fix build error Organization: m References: <20200826065231.14344-1-yuehaibing@huawei.com> Date: Wed, 26 Aug 2020 09:03:23 +0200 In-Reply-To: <20200826065231.14344-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Wed, 26 Aug 2020 14:52:31 +0800") Message-ID: <87k0xl7utg.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.102.4 at canardo X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing writes: > If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails: > > drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet= _cdc_update_filter' > > Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this. Ouch. For some reason I assumed that was always selected with usbnet. Thanks for fixing. Bj=C3=B8rn