Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0GafeSFbd2fPtfcu0y/EvUpmiwBOQchHPdbaWgNbaFwMHm/RSs9aiMrdRm9SDqqiM65Ox2xiXj
 p3EXs9Quf7WQ==
IronPort-SDR: KsKT0zQOlKI9ZRXe9nwwNG+Znb7WuamKHzseJep0AJhFaxdyjy1ipUOn6FK/RGr1LeijjSvGn1
 wWBgT+MsGYCg==
Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com
Subject: Re: [PATCH v1 2/9] extcon: extcon-ptn5150: Switch to GENMASK() for
 VBUS detection macro
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com,
        cw00.choi@samsung.com, andriy.shevchenko@intel.com,
        thomas.langer@intel.com, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, yin1.li@intel.com,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>
References: <20200818065727.50520-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200818065727.50520-3-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200826065920.GB12271@pi3>
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Message-ID: <f6552123-a01f-7d42-cc58-0a1da157e134@linux.intel.com>
Date:   Wed, 26 Aug 2020 15:33:54 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200826065920.GB12271@pi3>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 26/8/2020 2:59 pm, Krzysztof Kozlowski wrote:
> On Tue, Aug 18, 2020 at 02:57:20PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Switch to GENMASK() for VBUS detection macro.
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>>   drivers/extcon/extcon-ptn5150.c | 9 +++------
>>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> This is too simple change, should be squashed with 1, 3, 4 and 5.
> 
> There is no point to split each change a define to use BIT or GENMASK.
Thank you for the review comments and suggestions.
Sure, I will squash it as mentioned patches mentioned above.

Best Regards
Vadivel
> 
> Best regards,
> Krzysztof
> 
>>
>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>> index 5d9a8767646b..c816a6c1e05c 100644
>> --- a/drivers/extcon/extcon-ptn5150.c
>> +++ b/drivers/extcon/extcon-ptn5150.c
>> @@ -42,9 +42,7 @@ enum ptn5150_reg {
>>   #define PTN5150_REG_CC_PORT_ATTACHMENT_MASK	\
>>   	(0x7 << PTN5150_REG_CC_PORT_ATTACHMENT_SHIFT)
>>   
>> -#define PTN5150_REG_CC_VBUS_DETECTION_SHIFT	7
>> -#define PTN5150_REG_CC_VBUS_DETECTION_MASK	\
>> -	(0x1 << PTN5150_REG_CC_VBUS_DETECTION_SHIFT)
>> +#define PTN5150_REG_CC_VBUS_DETECTION		BIT(7)
>>   
>>   #define PTN5150_REG_INT_CABLE_ATTACH_SHIFT	0
>>   #define PTN5150_REG_INT_CABLE_ATTACH_MASK	\
>> @@ -130,9 +128,8 @@ static void ptn5150_irq_work(struct work_struct *work)
>>   			case PTN5150_UFP_ATTACHED:
>>   				extcon_set_state_sync(info->edev, EXTCON_USB,
>>   						false);
>> -				vbus = ((reg_data &
>> -					PTN5150_REG_CC_VBUS_DETECTION_MASK) >>
>> -					PTN5150_REG_CC_VBUS_DETECTION_SHIFT);
>> +				vbus = FIELD_GET(PTN5150_REG_CC_VBUS_DETECTION,
>> +						 reg_data);
>>   				if (vbus)
>>   					gpiod_set_value(info->vbus_gpiod, 0);
>>   				else
>> -- 
>> 2.11.0
>>