Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <f54e99e9bd1e25ad70a6a1d7a7ec9ab2b4e50d68.1595460351.git.fthain@telegraphics.com.au>
In-Reply-To: <f54e99e9bd1e25ad70a6a1d7a7ec9ab2b4e50d68.1595460351.git.fthain@telegraphics.com.au>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 26 Aug 2020 10:55:13 +0200
Message-ID: <CAMuHMdW7eWtkUURxvAwAz6cAHABLBk4qs4bLUXR3wuowQbn5Fw@mail.gmail.com>
Subject: Re: [PATCH] m68k: Correct some typos in comments
To:     Finn Thain <fthain@telegraphics.com.au>
Cc:     linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Finn,

On Thu, Jul 23, 2020 at 1:50 AM Finn Thain <fthain@telegraphics.com.au> wrote:
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Thanks for your patch!

> --- a/arch/m68k/kernel/head.S
> +++ b/arch/m68k/kernel/head.S

> @@ -1547,7 +1547,7 @@ func_return       get_bi_record
>   *     seven bits of the logical address (LA) are used as an
>   *     index into the "root table."  Each entry in the root
>   *     table has a bit which specifies if it's a valid pointer to a
> - *     pointer table.  Each entry defines a 32KMeg range of memory.
> + *     pointer table.  Each entry defines a 32Meg range of memory.
>   *     If an entry is invalid then that logical range of 32M is

Ah, lots of opportunities to switch to SI prefixes (MiB) ;-)

>   *     invalid and references to that range of memory (when the MMU
>   *     is enabled) will fault.  If the entry is valid, then it does

> @@ -2654,7 +2654,7 @@ func_start        mmu_get_page_table_entry,%d0/%a1
>         jne     2f
>
>         /* If the page table entry doesn't exist, we allocate a complete new
> -        * page and use it as one continues big page table which can cover
> +        * page and use it as one continuous big page table which can cover

Usually I use "contiguous", but the dictionary seems to permit both.

>          * 4MB of memory, nearly almost all mappings have that alignment.
>          */
>         get_new_page

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.10 branch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds