Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3514689pxa; Wed, 26 Aug 2020 02:27:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgEwrvl87iu7N4IYZ5g3oeTkBHkq7/cSWmj1UJ+qBhfQYW8sw/QpYP3SYYvfLK651WG7L3 X-Received: by 2002:a17:907:20c8:: with SMTP id qq8mr15564506ejb.253.1598434025635; Wed, 26 Aug 2020 02:27:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434025; cv=none; d=google.com; s=arc-20160816; b=bamo1JF/gXWaNUEEVIRDQYp8/vn5XlrIkjyX2/jDFJH5QR0N7JeGvSzd9Xs5bxKbL8 m/+DHBSWT2OA4JPuhmfW/c8wKf9XCbaKkqwBhbl9EjiKBk6TEl1y8zTYt85Jsosa2kuY wzw5YbsqypWPppPJhihJJ2Vz0Z4QMKc9s6dYre9aGSodmvoD+HvHMsk9d+lH//RuaFmO 8AEHurPdpqJO9N4ueBZUAa2ET1qWziqbP/i2ZEnradLTOHWR44Ya6ywgtkFFR38O0EOo qdpocrUX2CVDm3EMI3BLuGXiPy7AgU2kMfRIwAVdJVQZ4nx42M9cf35YU6OlCXxOWiw9 wTTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=sotJWssUogHGnVENvc/gD5IwqkJ1nWvp/NxtHhTVpCg=; b=d7g2r/GWv7CCv0cmD7AGgv6HizdVK560ZWyGfh7W0vyXPqqtJ3WE0t06YXgwsGT4Kl A3W2iUjmkiFW5vG4LfjdFDkNvpTQ4Y/Xzo23kd7OQMCK9EMfwVCgVFXnZvdNn/m2hIKY +0YG5/Kd52qv/M2y1+lFL5RlZ79JQvhRbPgskKAjvNISUku71oG37OcsvQXVivfsSQTl 7Q6y2b8M6f/iRXrTQquO7CePhNAHOGmqJARtJginfkxO61E85iyOEDY2SzDPUVBUpU/x yDNXvnqqdnmh1zlIgA8a1FWVKldmM94Z8dQWZTFzIPMvFadEwu1xse5EPT+y9+qrMNfP /r7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bh4si1120208ejb.193.2020.08.26.02.26.41; Wed, 26 Aug 2020 02:27:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727986AbgHZJWa (ORCPT + 99 others); Wed, 26 Aug 2020 05:22:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:36044 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727854AbgHZJWa (ORCPT ); Wed, 26 Aug 2020 05:22:30 -0400 IronPort-SDR: 5kqdthG520EFvOd0+cBX9F0BWPKX6ff3QNmF2jcG34YDM4AFaUc4CdgxCtJAfBpooaVKTE930E VdGmp5ZYuG5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9724"; a="174308237" X-IronPort-AV: E=Sophos;i="5.76,355,1592895600"; d="scan'208";a="174308237" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 02:22:29 -0700 IronPort-SDR: iGxGPqwz0Se3mmhRbGj07Qjo9Mx6Pbd65dfS1RpDmv0aUu8nqc+dPgNk07Sxgft5JnbII566nT 2RmQxfDFRsaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,355,1592895600"; d="scan'208";a="329159129" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 26 Aug 2020 02:22:27 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kArZE-00BWYQ-Pt; Wed, 26 Aug 2020 12:18:04 +0300 Date: Wed, 26 Aug 2020 12:18:04 +0300 From: Andy Shevchenko To: "Ramuthevar, Vadivel MuruganX" Cc: Heikki Krogerus , Linux Kernel Mailing List , MyungJoo Ham , Chanwoo Choi , thomas.langer@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, yin1.li@intel.com, krzk@kernel.org Subject: Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Message-ID: <20200826091804.GF1891694@smile.fi.intel.com> References: <20200818065727.50520-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200818084044.GD1891694@smile.fi.intel.com> <69e13a74-8b8d-cbc0-915d-ce289e7d4a70@linux.intel.com> <20200825081935.GE189773@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote: > On 25/8/2020 4:19 pm, Heikki Krogerus wrote: > > On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote: > > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote: > > > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX > > > > wrote: > > > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote: > > > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: > > > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC > > > > > > > boards to detect the USB type and connection. > > > > > > Internally I meant you can send cleanups, but couple of patches here are the > > > > > > features and were still under discussion... But here we are. > > > > > > > > > > you mean asking us to implement the Heikki suggested as below.. > > > > > > > > > > Heikki Krogerus: register the port and the partner attached to it with > > > > > the USB Type-C connector class in the driver. Is my understaanding > > > > > right? if not, please explain it. Thanks! > > > > > > > > When you mention somebody, don't forget to Cc them (now done by me). > > > Sure, Thank you > > > > So the patches 1-5 are fine. The rest needs to be rewritten. > Already Krzysztof submitted all the patches and got approved, so we started > sending only one patch which support to Intel LGM SoC based boards, Thanks! I'm not sure what you meant by above. Krzysztof suggested you to squash all first patches into 1 (or two) and he approves it. What you have to do is follow his advise and send v2 where it will be one (or two) patch with his tag attached. Krzysztof, is it correct what I'm saying? -- With Best Regards, Andy Shevchenko