Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9OZKk8jEcvCf/m3dpFJVwSgODe4S/NTgM3/BJZwc+totVibwYjJskgkHIvH1luqMNDHkMlI4mG
 zgIlbku+Y8eVt0IikwZWK+8XhVAfuuhKfvo6Ykxhyaft6JuOexl8+hqdSIl5NVP1hXwUYj/llX
 S9Mpzl0lQ8EnZP5QpWa7B2qjdM1zHr9E+qiXNuF//7nrNIEtiTi98bUk0+cgpPYPIbLWHAkd+y
 Ey93PlVoyr/4vvUSnPoGqUh+eUd1OoVQeFv4fVl+ket3cgLTjv0cxIWJmbgrBGi0KCaLtL26GJ
 i24=
IronPort-SDR: YJeyxRPZU91peRDZT+5Vm5Z4NR4Ycx+N+xtKloknBbXfhabJim5XpCZLDn9YzBXcE4nYPq0kKu
 y0rzgEi0Y0MefjCCBwAjS/YRoF3JNbxoOFeAuEU++hmnORUiwzvBVX1dWNqGDUFw7TjwBVclyb
 8F8TaH874gCnt/7gCtT0UTlWf4KmIlz3pQLYsR+kcF1wCVqJOe64CdoYyB71/kJLAzFMirSRCE
 hz+NXVb+ZIsWJkOPbfYo7W8qH2UqejHbxLKhqnojoD0cK07w2E9bm9/V8PqkTJf7QS//C+PVLB
 7kA=
Message-ID: <53f5f17735fc2f0ca061a321969bbb131e55efff.camel@ew.tq-group.com>
Subject: Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl:
 tqma6: minor fixes
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Wed, 26 Aug 2020 12:32:17 +0200
In-Reply-To: <CAOMZO5CP=wtJ5ZScyb0NrRMW0FR0FAGVKRFq9JpFcAoZppn_bA@mail.gmail.com>
References: <20200824091013.20640-1-matthias.schiffer@ew.tq-group.com>
         <20200824091013.20640-2-matthias.schiffer@ew.tq-group.com>
         <CAOMZO5DSX1pf3xxo=CGvgPmHcjMJoWFx74grVJBckSmjtF-RGg@mail.gmail.com>
         <4b7d57738ce8e2130c4740a0f3f973fbaf60a7cf.camel@ew.tq-group.com>
         <CAOMZO5DYrkEb_G+EYAGrc+qjSsbjRdeBUU3tJUfkU6tjgNm_7g@mail.gmail.com>
         <7a59492e46f34d213b83f7182c7db73954c5a9c7.camel@ew.tq-group.com>
         <CAOMZO5CP=wtJ5ZScyb0NrRMW0FR0FAGVKRFq9JpFcAoZppn_bA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote:
> On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer
> <matthias.schiffer@ew.tq-group.com> wrote:
> 
> > Makes sense. Does the following logic sound correct?
> > 
> > - If num-cs is set, use that (and add it to the docs)
> 
> I would not add num-cs to the docs. As far as I can see there is no
> imx dts that uses num-cs currently.

But the previous platform data that was removed in 8cdcd8aeee281 ("spi:
imx/fsl-lpspi: Convert to GPIO descriptors") set different values for
different boards. So maybe some DTS should be using num-cs?


> 
> > - If num-cs is unset, use the number of cs-gpios
> > - If num-cs is unset and no cs-gpios are defined, use a driver-
> > provided
> > default
> > 
> > 
> > I'm not sure if 3 is a particularly useful default either, but it
> > seems
> > it was chosen to accommodate boards that previously set this via
> > platform data. All SoCs I've checked (i.MX6Q/DL, i.MX6UL, i.MX7)
> > have 4
> > internal CS pins per ECSPI instance, so maybe the driver should use
> > that as its default instead?
> 
> I think it is time to get rid of i.MX board files. I will try to work
> on this when I have a chance.
> 
> bout using 4 as default chip select number, please also check some
> older SoCs like imx25, imx35, imx51, imx53, etc

Hmm, I just checked i.MX28, and it has only 3 chip selects per
instance.