Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4.19 65/71] powerpc/pseries: Do not initiate shutdown when
 system is running on UPS
To:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>
References: <20200824082355.848475917@linuxfoundation.org>
 <20200824082359.202438041@linuxfoundation.org>
 <20200825195620.GB27453@duo.ucw.cz>
From:   Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Message-ID: <268a861f-59ac-679c-7507-d685d059a2ab@linux.vnet.ibm.com>
Date:   Wed, 26 Aug 2020 16:44:12 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200825195620.GB27453@duo.ucw.cz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/26/20 1:26 AM, Pavel Machek wrote:
> Hi!
> 

Hi Pavel,

>> We have a user space tool (rtas_errd) on LPAR to monitor for
>> EPOW_SHUTDOWN_ON_UPS. Once it gets an event it initiates shutdown
>> after predefined time. It also starts monitoring for any new EPOW
> 
> Yeah, so there's userspace tool, and currently systems _with_ that
> tool work poorly with UPS.
> 
> So you have fixed that, and now, systems _without_ that tool will work
> poorly.

User space tool exists for long long time (more than decade) and its default tool
on pseries system. Also user space tool behavior is not changed for long time.

The original design was to forward UPS event to userspace and let user space wait
for predefined time and then initiate shutdown.

Previous fix accidentally initiated shutdown as soon as system switch to UPS power.

> 
> That's not a fix for serious bug, that's behaviour change. You are
> fixing one set of systems and breaking another.

Without fix, as soon as system switches to UPS power supply, kernel will start 
shutdown process. which is not correct. Its actually impacting customers running 
Linux on pseries LPAR mode. Hence I have requested this fix for stable tree.

Hope this clarifies your concern.

-Vasant


> 
> I don't believe it is suitable for stable.
> 
> 								Pavel
> 
>> @@ -118,7 +118,6 @@ static void handle_system_shutdown(char
>>   	case EPOW_SHUTDOWN_ON_UPS:
>>   		pr_emerg("Loss of system power detected. System is running on"
>>   			 " UPS/battery. Check RTAS error log for details\n");
>> -		orderly_poweroff(true);
>>   		break;
>>   
>>   	case EPOW_SHUTDOWN_LOSS_OF_CRITICAL_FUNCTIONS:
>>
>