Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp104833pxa; Wed, 26 Aug 2020 06:05:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6vOAkeaNrkgVpozejZAc53mNmWKI4ak6wdx+BCQCRWOIdIWnXDQ0ETgoxU9EuD49gfwEw X-Received: by 2002:a17:906:4a99:: with SMTP id x25mr16197443eju.439.1598447147907; Wed, 26 Aug 2020 06:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598447147; cv=none; d=google.com; s=arc-20160816; b=Y+cm91LhuJ5tntkzabg1uNPcqnlnvNRHgAbm1uMfBmiIj/LacRv+XDW9oiJ4PWYrUc 5ds0JRGDtVN7458U51pUz08T6kh3XAbCjY27OZxpAtciu1g+e/HBBBwKjNdcwcuZ6P7M Su5PBBcNGA0g8Wa2jOe2qYns6hiUylZB0haYVlRp4ePN/QaBHtrWJ4n8MZTv1QMtP8j/ OoE9tWt+fZe8hxliWax/7hQJ//01z+Ys+79QO9IGzjVPNhWmra1Af6E21bStBbKnnDz3 fvTeEaahhP8CMJCa+BMAZG64zKlH1WNmjPK9QbICQLuybgbLz31OTaawZa1jPSwYsXMY PhOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5u1D5S4hoVeCokFlRoXkBVpzv2N9WFWKvXd4EhVfhi4=; b=wcgGybcnL1XL73aTT3VZ2uiRQvZvVErufxkIUE/3XO69vUc46dxVxXiMCqlPp8eUG3 y6mR9eeskHvx+VG+SlCR/aOA4oinXo+yVq7ujZfQm6T7oVA69bMN5+g3yc7TUEbS4u0y p7sHKDq43ecShRib4uDvKzQOu2XIQYD0mutedVjkG3mhFWL+S2GzmNZfhkebjr1rQJjC h243mzpxV0VDqAWdINfq1WUdpPfjk4d+q8cEjS0jv0+/Lyl/xVwQo/fuKCkfoH2bJF+W mgrfefD0hMSf6utKok802ecmDU9VXh8O6pcZneRzFqbmbBJyChy6mK8EAgwqXHnndWkK 7HlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=rA8b32iO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p13si1204497ejb.144.2020.08.26.06.05.24; Wed, 26 Aug 2020 06:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=rA8b32iO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730143AbgHZNBs (ORCPT + 99 others); Wed, 26 Aug 2020 09:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730134AbgHZNBi (ORCPT ); Wed, 26 Aug 2020 09:01:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D54CCC061756; Wed, 26 Aug 2020 06:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5u1D5S4hoVeCokFlRoXkBVpzv2N9WFWKvXd4EhVfhi4=; b=rA8b32iOdfxrZ/AbJyc/6/cBOA B8Bddh4hnWGDFx6m7P99J4EWdzI8+2+wK8G50+THis5kC2M+0Stkb4r1EjeJ607sDckOUdik4yjU7 eKZBNyp63OMiX8VnVEMcqEaz55bOC+VJ8ieLJWvRjE8tfRRWRyCpdPgZRpS6JPwghd3+r2jq1uZ0c +uXrVPtP2mW2B9BLt7s89IXAtiMLNDmK/WpCEp9nq/nMzGjKy40vxKaueDMxl6TOddgBK4V26eAtO kXkFJQ2+r5f6I3eihxFu2j9uVWDsNZ4bvVH4OVliy0f5Dpk/D8EwqHfp9GmzVF6+4mNULTJrhZJnt 20rPuOUw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAv3K-0002lN-QU; Wed, 26 Aug 2020 13:01:22 +0000 Date: Wed, 26 Aug 2020 14:01:22 +0100 From: Matthew Wilcox To: Jinyang He Cc: Huacai Chen , Jiaxun Yang , Andrew Morton , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Tiezhu Yang , Xuefeng Li Subject: Re: [PATCH] MIPS: Loongson: Fix complie errors without CONFIG_SMP Message-ID: <20200826130122.GR17456@casper.infradead.org> References: <1598446407-8845-1-git-send-email-hejinyang@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598446407-8845-1-git-send-email-hejinyang@loongson.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 08:53:27PM +0800, Jinyang He wrote: > +++ b/arch/mips/include/asm/mach-loongson64/topology.h > @@ -4,7 +4,11 @@ > > #ifdef CONFIG_NUMA > > +#ifdef CONFIG_SMP > #define cpu_to_node(cpu) (cpu_logical_map(cpu) >> 2) > +#else > +#define cpu_to_node(cpu) 0 > +#endif Are you saying you've enabled NUMA without enabling SMP? Does that make sense?