Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Aug 2020 16:31:25 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-m68k@lists.linux-m68k.org,
        Greg Ungerer <gerg@linux-m68k.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: mm: Remove superfluous memblock_alloc*() casts
Message-ID: <20200826133125.GB69706@kernel.org>
References: <20200826130444.25618-1-geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200826130444.25618-1-geert@linux-m68k.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 26, 2020 at 03:04:44PM +0200, Geert Uytterhoeven wrote:
> The return type of memblock_alloc*() is a void pointer, so there is no
> need to cast it to "void *" or some other pointer type, before assigning
> it to a pointer variable.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  arch/m68k/mm/mcfmmu.c   | 2 +-
>  arch/m68k/mm/motorola.c | 5 ++---
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
> index 2b9cb4a622811390..eac9dde65193443e 100644
> --- a/arch/m68k/mm/mcfmmu.c
> +++ b/arch/m68k/mm/mcfmmu.c
> @@ -42,7 +42,7 @@ void __init paging_init(void)
>  	unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
>  	int i;
>  
> -	empty_zero_page = (void *) memblock_alloc(PAGE_SIZE, PAGE_SIZE);
> +	empty_zero_page = memblock_alloc(PAGE_SIZE, PAGE_SIZE);
>  	if (!empty_zero_page)
>  		panic("%s: Failed to allocate %lu bytes align=0x%lx\n",
>  		      __func__, PAGE_SIZE, PAGE_SIZE);
> diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c
> index a9bdde54ca350197..3a653f0a4188d4af 100644
> --- a/arch/m68k/mm/motorola.c
> +++ b/arch/m68k/mm/motorola.c
> @@ -227,7 +227,7 @@ static pte_t * __init kernel_page_table(void)
>  	pte_t *pte_table = last_pte_table;
>  
>  	if (PAGE_ALIGNED(last_pte_table)) {
> -		pte_table = (pte_t *)memblock_alloc_low(PAGE_SIZE, PAGE_SIZE);
> +		pte_table = memblock_alloc_low(PAGE_SIZE, PAGE_SIZE);
>  		if (!pte_table) {
>  			panic("%s: Failed to allocate %lu bytes align=%lx\n",
>  					__func__, PAGE_SIZE, PAGE_SIZE);
> @@ -275,8 +275,7 @@ static pmd_t * __init kernel_ptr_table(void)
>  
>  	last_pmd_table += PTRS_PER_PMD;
>  	if (PAGE_ALIGNED(last_pmd_table)) {
> -		last_pmd_table = (pmd_t *)memblock_alloc_low(PAGE_SIZE,
> -							   PAGE_SIZE);
> +		last_pmd_table = memblock_alloc_low(PAGE_SIZE, PAGE_SIZE);
>  		if (!last_pmd_table)
>  			panic("%s: Failed to allocate %lu bytes align=%lx\n",
>  			      __func__, PAGE_SIZE, PAGE_SIZE);
> -- 
> 2.17.1
> 

-- 
Sincerely yours,
Mike.