Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp125442pxa; Wed, 26 Aug 2020 06:34:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5Rhhn+Gyl7uWIjS0wYloApTt7/9jMR+L4OAZXDrcOGx6jHnsiGONGQFDEUxyblD/6A1uW X-Received: by 2002:aa7:d80c:: with SMTP id v12mr137898edq.119.1598448845124; Wed, 26 Aug 2020 06:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598448845; cv=none; d=google.com; s=arc-20160816; b=W1bzYxf0xhA5YYg4rrkmqczoug2XOjZgYNUq+2NtOImZR2vzkarnSIGfuyYom8beDY 8wAGwrZ5I/z9sDXXJ6V4zOmY6jvZxm+jnVNxcVOlt3C8gy61jcUaN8FKPIAaAbsKebdG 42irUjKX3X8M06NQ9LpbtPMyw1dNas4qzqPQV5l+/GYzKim/JasfPiOy3Nf/vFdW6y2T IFdmn7lg0m5Df+BztWofe9eBG71/xXBLuzPzEFQW0n3C8z1WJgZTKuETizRe3NH/CDPp BzMjckw7KUS1hftAP3sP5p5ghbiK/XZDhuy6yfVemXbBJ+APZnTHHS2RNTk/W1m0HeGz cxBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FkhfN3cT3cQJ7PHsuf80oD0j4Kw1XGx7zDFLh/m4hhg=; b=ToI3B61DfzVGZk3dHShE0To2R9UOAF2KKma37eLFCTsY4ebJwJ8VOHOcDvTJEJ6zRR m8i1JDkWMVn5KSTmALSiUeW1FbLcBWYLVtN1IA9uyLTHaFdiyzwKI1Ho50qSyJULN0rj 1cyitXRFTUS/ozbCyA7PeHd/gayYESVQtwCR0x96XRK4toYxISp4H3xrcHj5sI8C1jhI c9CBasCZylTRXknbvvwHK8gg7Q25CJ8eXn3O3FCqhh6CriJ2sj43p2Bzbg9q57Ob8POo EmIYtIillVNbkHfbzRNFB2ABYHbJkNtrFDCITkRsGD3JzRT+LlpzCJHiQZ64At2GUNT6 7yWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=UqSLNW2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si1406881edr.11.2020.08.26.06.33.41; Wed, 26 Aug 2020 06:34:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=UqSLNW2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730238AbgHZN32 (ORCPT + 99 others); Wed, 26 Aug 2020 09:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730220AbgHZN3Z (ORCPT ); Wed, 26 Aug 2020 09:29:25 -0400 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD6E7C061574 for ; Wed, 26 Aug 2020 06:29:23 -0700 (PDT) Received: by mail-ed1-x541.google.com with SMTP id i17so198766edx.12 for ; Wed, 26 Aug 2020 06:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FkhfN3cT3cQJ7PHsuf80oD0j4Kw1XGx7zDFLh/m4hhg=; b=UqSLNW2hVsumXhgcQeQDY4OnmCva9EEDgjjcCwt9TV+Zuz4I6QA8U1eEubCj2/AJ5h t2ivF2dl8jJ/cr4v01TBDLpXDGxXwKcjESKz2yNujWqKdU0mTRg+GbDecTKczbpwOvdA ObTvuOgAv9+DkNzmlY3xhEf/v6MHVjY7Vf3iE+Pi8MtWGi4nT6O08H/ZWC39lfvKPFBv KfhltH5++yR/hM5qe+d7Ydo8ixo8iHTg7RSiCW1R7/xSEyXaWnJnGa3pmPMAmjwVb2B+ RZfDlP/Ez7m7YLxVcJWZWERD7YrxnqY1y7oDnxLqUXJX9QFYWfZH0WV6oACAO/2zV46h 5APA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FkhfN3cT3cQJ7PHsuf80oD0j4Kw1XGx7zDFLh/m4hhg=; b=H0CTgKaHHWvDk2dh6DcYyXUVvu4rWdWcGhdSL6dAxEoe68CtDtT3qVKSksfw3aR5Wm qPcFHV4KUS/Vj1ErpRJJqEqc3cUxS5RreE/F+xPzn1WRW93NKB6PtdLo9ENhMIv4d0rE uSLXFrMruPRXA509KKKye8Q31snn+UKbYbq4RTB/ODz/T8042/kUMp6w2KDSMIBNvEiG nyS9XM/x+joAtXpjEG6x4QEhTO60YpcnhcwP6IXaGp/D+En9UZ5yL+cQEcpUlO/FIcG/ Mui6aOK7Ny8+5zV3JJQHDHkPbmfHUPOAcDCKtdtL0K9ZGwctFi1ezIRqm5umAxJdYc0z yRVw== X-Gm-Message-State: AOAM532lLEbz9uK+Xs+JZNOARSQoKYa3U+YIkagD6b52QDeYH7v/Jifm wa3QFLLEDBuV7xVPx2hkRNy7yI3kSdlO3uEGAaEXJrwzgg== X-Received: by 2002:aa7:ca46:: with SMTP id j6mr12617276edt.128.1598448562248; Wed, 26 Aug 2020 06:29:22 -0700 (PDT) MIME-Version: 1.0 References: <20200826040022.5297-1-vulab@iscas.ac.cn> In-Reply-To: <20200826040022.5297-1-vulab@iscas.ac.cn> From: Paul Moore Date: Wed, 26 Aug 2020 09:29:11 -0400 Message-ID: Subject: Re: [PATCH] audit: Remove redundant null check To: Xu Wang Cc: Eric Paris , linux-audit@redhat.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 12:00 AM Xu Wang wrote: > > Because kfree_skb already checked NULL skb parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang > --- > kernel/audit.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged into audit/next, thanks. -- paul moore www.paul-moore.com