Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp157525pxa; Wed, 26 Aug 2020 07:20:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw6UB1bAlmfSSF9quPPfuHTaHitdcWivhzV+4EldhM9ZLIZw+QIygEHiGkHyU3HvEFMbxi X-Received: by 2002:a17:906:d209:: with SMTP id w9mr15617729ejz.93.1598451643690; Wed, 26 Aug 2020 07:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598451643; cv=none; d=google.com; s=arc-20160816; b=uOb3NSFgF/vQ75ePIla6ulo0RDF0BjFJv/t7518NzM9iahhUfnHuTS1x5jdrKqba2/ yZVZk+tVMoW5M0951Z8MMGw30n6Fgv8Tjwx3YEBPleVrwPKpCxtSVup8lO+Sb2TxIsCs yTZcMCwB+17+IeTb/IHPnSnm69caaFeK6UavMMWzG74C52FcH4I7YrJUmpT6y9Fbdced 4oeWNODMjkgweON8u/kQk3jdZMJ0QO22f/5p9L2iSW9LzYDXKJEhSWapEXU3IEpMnWxP OufwBFlTEOYwjU4jjUtOZfAs3hKHcN52i1EVpZhjfGdSgnP/Brk6lIGEoyQiIjFJAXlY MX5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=I0i2q5/JqUekGhzJe594DvzcUM3i+my4rruJmCWxWeY=; b=vgtBYgD3dp/Zf3DqIaOXQH5+btaRscavv9RQuggzcAnMI9G1s0Clp6GBUgNuTMc8Ax R7XPHFAynN5gmaWC0rhzwSpR/tzns+Loy8UxsiHd58Vrv7ShLs8CoKAFGiDhrKjWyN3a Oz2VRLRjndeHkmnF2RxHaaU1kdCEsAFGFdBED2dxu/+hA/htZH9OM5ynSRvKohIQZbn4 1KOkNwwts/5cFDNEGO4Vikb7m7g2vE0W/41lGIomcpJmZoljUMYlk/Rm0Dptejxg7pWE 8F2uNV4SKHfDsgWP1eGQ8TgIk447yjzN7M/gAuXSvU9deZPo/QdT2Mq9frE0h8jH6Za/ bOVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KvjqRbON; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d11si1419805edu.494.2020.08.26.07.20.20; Wed, 26 Aug 2020 07:20:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KvjqRbON; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728358AbgHZKUc (ORCPT + 99 others); Wed, 26 Aug 2020 06:20:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:42574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728161AbgHZKUa (ORCPT ); Wed, 26 Aug 2020 06:20:30 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B08352071E; Wed, 26 Aug 2020 10:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598437230; bh=I0i2q5/JqUekGhzJe594DvzcUM3i+my4rruJmCWxWeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KvjqRbONInpcWqBDaQcpXLXdf7/ssIOhM++ISKq2qwrU7IDsH5HRQAfbJu8/hHbH7 1YpZXrgRtxv53dgb6kD7MFF0tXw6gvqZYI7EjFmyjPi4eCgf7pSCOQFAbTrf1U+CFS OnQeDDI5a+yaKtSGiIIiyLc0w+g9ta82YCulmo74= Date: Wed, 26 Aug 2020 11:19:54 +0100 From: Mark Brown To: Qiang Zhao Cc: Vladimir Oltean , kuldip dwivedi , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pankaj Bansal , Varun Sethi , Tanveer Alam Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support Message-ID: <20200826101954.GD4965@sirena.org.uk> References: <20200821131029.11440-1-kuldip.dwivedi@puresoftware.com> <20200821140718.GH4870@sirena.org.uk> <20200822152118.rlwbcgfk4abjldtg@skbuf> <20200824112505.GD4676@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cHMo6Wbp1wrKhbfi" Content-Disposition: inline In-Reply-To: X-Cookie: Should I do my BOBBIE VINTON medley? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cHMo6Wbp1wrKhbfi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 26, 2020 at 08:19:41AM +0000, Qiang Zhao wrote: > On Mon, Aug 24, 2020 at 19:25, Mark Brown wrote: > > Yes, it's a legacy from bad board file conversions and shouldn't be used at all. > I saw a lot of driver assign spi_controller -> num_chipselect directly, should we do like that? Yes, you should know the number of chip selects based on the controller. --cHMo6Wbp1wrKhbfi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9GN0kACgkQJNaLcl1U h9CfaQf/cFN7Z+7Su3oU98AYqh3AS6StbT42NYYmfMw0bX/Ymf4mNxqFU4DR+fsU hINOEiBo8SVc4p9GMRK7hSCqOuLFrViWewEPcnfr3D4VISJ7bLAAP8SjOGa5YgTZ WDcXJ4STYGrR3dgxbMjyL/f1JKfMuMRYoTw2uc+uNZe4mnBIkfCGoocxdA2ZGGUc Qx+MrNEDTmi1xNhMFhorO/uKKNsdNLKycljcdZ3swOHOs7L064bgeICJmnpK0n3Z MRKyT+C3jvkcnojv55s9wI2xqcI2jtRioTAZkeZOfP+4bqqf1jCDs7xJkKMMRZwO idSiTyw6bsDFEL/CwcKiU1yKpG10Uw== =1dzn -----END PGP SIGNATURE----- --cHMo6Wbp1wrKhbfi--