Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp157899pxa; Wed, 26 Aug 2020 07:21:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxW3ta+XYTCeMKc65DLldgGjoU/2SQJloKEndhnjUD6nyvh7HFtF3eEZVG5zWPwH7b9vPrk X-Received: by 2002:a17:906:15c7:: with SMTP id l7mr15759790ejd.208.1598451670620; Wed, 26 Aug 2020 07:21:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598451670; cv=none; d=google.com; s=arc-20160816; b=TstRTf1OoQx7LzVzp3EPtPpuOFaE5UrqJIEGeaO/1dLjAaR7b5FsPLuUctZtEUi9o0 pjzaBwcUT4FeIOeqfyqPAw505BkeSJyDe8L4Vp0V4OuJmEbBHNNVRd7SJZoB/0ABA33b pPcHM0fo+30av+2lufl1dHWXE6l8H2vxmjtzdB3Z5RhlRgjIpF25jkQB2lqxHBAy1XM/ V8wbicNGUBohnqkJiTCs0aIRZxssE94a1On0qk+53DHMIKkBg2GQzb19b9uuYoKh3mfR fpyhfIWhY5f2vkJGAvxYfCH6DOF1Bi+bWT9nvpc2/HFpdP1pCOAHVomgnYclystWHuXT O1cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8e7m1CkmXpgJBEIhBkOz8FSttb96UAPZGvqZLIsdgA0=; b=qNVgHgm37Y+V/1GB5Fcg2mBpRkdjuMy/c3PplYVRUVmro3V++5cBKN3lf0Y14bdgMZ rBI+GnMPzqQsTVlj2mq0d00bSLc0Y78macmVwYa7xSV76RHcW9mBGWAKJKh7DmnrS8kr wRVyc8FAv1leJo8mzCc3mSr17tWiNjahszCb2BB1nbDrtOjqT84keg9AGRsDN4TwRkmQ pBVo6Rbimu6Nhb4bqNpG5G8/MmJwNxDdeK0Ww/un2hrl9f4UNxBhqPja5FXm1mV/DF/3 Ud0m6YceSkLhB/mS2AR2JumYxjPOdwRmE8BbSlDvLCPHOp+uqD0jxRYDg4UbEKA44OOg Ge9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=R0WUt2Nv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si1632834edc.174.2020.08.26.07.20.47; Wed, 26 Aug 2020 07:21:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=R0WUt2Nv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728380AbgHZKZw (ORCPT + 99 others); Wed, 26 Aug 2020 06:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728132AbgHZKZw (ORCPT ); Wed, 26 Aug 2020 06:25:52 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DDAC061574 for ; Wed, 26 Aug 2020 03:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8e7m1CkmXpgJBEIhBkOz8FSttb96UAPZGvqZLIsdgA0=; b=R0WUt2Nv3A5DmntgkldazUgIsg +wipts7wLWsx8Ee7V08Zf1SIPg+bl58SHK44F/NQGL4q1OY5eQiPjAQcbNISnhblKl6loFFtt8kfk sStiby/f6BiBrh4Y029E0Z+nD1M8HKbkK48mlqYY/hekPwLSlSiGIRb6N39Z5nocpmMaCm3AaxrB4 Cnongp00g9pjTOTzECeVMET2NsTyL0mVLmmACRp3vccGpeAYi7ic9RQQb+DIxMIgIgDEHh2L05Ejm BbjUfz752681Q7l7WTCe9VXH2/T1iCNCJZEkUXoTqxFfGlWqL2eyib1U2pJk28DxKzljWfOuVnKTc 3Xd73iTQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAsck-0006eU-QK; Wed, 26 Aug 2020 10:25:47 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 99111301A66; Wed, 26 Aug 2020 12:25:45 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 823BA2C016759; Wed, 26 Aug 2020 12:25:45 +0200 (CEST) Date: Wed, 26 Aug 2020 12:25:45 +0200 From: peterz@infradead.org To: Masami Hiramatsu Cc: "Eddy_Wu@trendmicro.com" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: x86/kprobes: kretprobe fails to triggered if kprobe at function entry is not optimized (trigger by int3 breakpoint) Message-ID: <20200826102545.GF1362448@hirez.programming.kicks-ass.net> References: <8816bdbbc55c4d2397e0b02aad2825d3@trendmicro.com> <20200825005426.f592075d13be740cb3c9aa77@kernel.org> <7396e7b2079644a6aafd9670a111232b@trendmicro.com> <20200825151538.f856d701a34f4e0561a64932@kernel.org> <20200825120911.GX1362448@hirez.programming.kicks-ass.net> <20200826172239.ff175be78ee5f3a4380579c3@kernel.org> <20200826180645.9b609fc05df2a149564df1b8@kernel.org> <20200826190041.2d0ff0fbe154ba62163b0c00@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200826190041.2d0ff0fbe154ba62163b0c00@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 07:00:41PM +0900, Masami Hiramatsu wrote: > Of course, this doesn't solve the llist_del_first() contention in the > pre_kretprobe_handler(). So anyway we need a lock for per-probe llist > (if I understand llist.h comment correctly.) Bah, lemme think about that. Kprobes really shouldn't be using locks :/