Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp162187pxa; Wed, 26 Aug 2020 07:27:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbtXoeY5peVynrUB2wOCR6ucRf3SbanLbknhMqnL16otQdSjyAXKI1ff1lBc1EZ1q8f9V5 X-Received: by 2002:a50:e004:: with SMTP id e4mr15020420edl.114.1598452038699; Wed, 26 Aug 2020 07:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598452038; cv=none; d=google.com; s=arc-20160816; b=E2OKNs9rubPQujY5lQqytwEO9/TQ8rYor+VHbfT3ILzPBy4YqPaTHYacI2OSs5vSmL 0i3GRUdWc/d0kuNrHXSKW3Nnz6KSxF2AFUqUhKYdmk8PI9kw9GadaeLf/85v8fNAvR3F zw0MFP+JLr8mtRNCuHnN9ULh0lvxz3Ls0L7awJG7VjlLcZNVYAQgRxymL1RCOZ9au6Qx mXmBhJwZyhjJX4ATOr4DWkQC72B40bC/Qc/CRYwG1cyxqlwO49fgurzmAaWdFBx3gPyd YZLNHL/Lc4zML+LWueteS7+qH9s+FIAgApzu70V348vud4vcTmjsOVbH7mRy1E29GK4u pnew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IrP6ayckjNJ1DXpVyleRBUcFlQaxWlVGGvYCRU/uzd4=; b=qwa4aTd8uOnSKzNhbFkI8C/OR732RH5XCV57/H5LKy/5HsMMsdgUnr5ZRDlrGmLumW e/8Rrg6oGESlHlGeNtK+hxhURg1idObAgoihE0nXkQHNY0RWxnHZY7Lm+BxrR+Hef+Pu u2eaomSP7Iaqbt3q4aVSNiOxaKbb0wsiGlRVjl0Khe3pXJgDHVPN3MpKkh8dZLUiTAFn lFxn8yKolZ85PqC5aVA/dlqY/vTueHbC+L8Ko7FJzy1CribSY18G6OYL85hKC2rFvi0Q NNyhn4jAp+i0VM1EsvK+NpraalQQ5wpi58cwTmCE/zgZVuqJM5+KHROy8TfmAK7s7QnM zEqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=twlNdYtB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si1528287eja.95.2020.08.26.07.26.55; Wed, 26 Aug 2020 07:27:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=twlNdYtB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728891AbgHZLEO (ORCPT + 99 others); Wed, 26 Aug 2020 07:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728660AbgHZLAi (ORCPT ); Wed, 26 Aug 2020 07:00:38 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6961C061574; Wed, 26 Aug 2020 04:00:37 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id w25so1802186ljo.12; Wed, 26 Aug 2020 04:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IrP6ayckjNJ1DXpVyleRBUcFlQaxWlVGGvYCRU/uzd4=; b=twlNdYtBtcwaVvGPQQqBMGYo+BCqGNAMnQ06scY1fvZsCpKwWZRwSByvNXbYYnRfPu 9bHzuP2ndjv2STYV5bjZ0ZArEPuWmY++WTwVe6+fioivo83/P+iA4jK9tENhV4b40Qar YuRhz3Qgr6mWXHMLKdDoV4yUjhv6aAXsVl20wj6VxzH/5KGABewzMz2J+8caqlFiWqMh XhFfcXdRWAvNaBCe+jUzB5jEAABOgKFbixVC6GIwJhflNmvOXylZ9k75sijC6TnL5CMa kfGa/rHeWDHedGF59eqknU2Aupage26bsMENg5mNG9ohiFwl9Q/o8O2WOmNHorNqQ0Un AR0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IrP6ayckjNJ1DXpVyleRBUcFlQaxWlVGGvYCRU/uzd4=; b=caiMLUZm0QvXudMQxYri6GAp2g7KfVoIY5onI3wx/FzcA/MMVe3NIXAujX1lw8o+KP Glw2qICivtJYlQxXtcJKSpQEw7qiUdqFhhhmuItUGitrz8DhWPgwMacg2+OdaS4yKa1t bPFqGS8irAx/GziluopyQM8VG0ZfKbLYXAjJ/p0QU/8G6ISMdJklaX1d4F3e6SW4vM+A Bnm0wbpLXhVkSfpfOCp7Wqta7VxHT0iPXoG9e6TfWURGSwnKx2U3zAfa5KVimqMQn31p ZoYutt/SiZB/c5h2LoUtldcGgi9CdDJd6INbtXRne7kntOcI3IkSGuFCcHLYaj7qAvy1 J2GQ== X-Gm-Message-State: AOAM532GN/p0KXZBojAnQu+Or3WitpPdos6TTSdTVRs9t39RrWEZrKtj oCfiIBUQJzERi64N5NhobbpKj8U3iXsJ5CTQOVr/IAz4 X-Received: by 2002:a2e:80d3:: with SMTP id r19mr7356055ljg.310.1598439635750; Wed, 26 Aug 2020 04:00:35 -0700 (PDT) MIME-Version: 1.0 References: <20200826092606.2910-1-dinghao.liu@zju.edu.cn> In-Reply-To: <20200826092606.2910-1-dinghao.liu@zju.edu.cn> From: Fabio Estevam Date: Wed, 26 Aug 2020 08:00:24 -0300 Message-ID: Subject: Re: [PATCH] [v2] media: mx2_emmaprp: Fix memleak in emmaprp_probe To: Dinghao Liu Cc: kjlu@umn.edu, Mauro Carvalho Chehab , Hans Verkuil , Fabio Estevam , linux-media , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinghao, On Wed, Aug 26, 2020 at 6:31 AM Dinghao Liu wrote: > > When platform_get_irq() fails, we should release > vfd and unregister pcdev->v4l2_dev just like the > subsequent error paths. > > Fixes: d4e192cc44914 ("media: mx2_emmaprp: Check for platform_get_irq() error") > Signed-off-by: Dinghao Liu Thanks for the fix: Reviewed-by: Fabio Estevam