Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Aug 2020 13:14:25 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Sean O'Brien <seobrien@chromium.org>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Wei-Ning Huang <wnhuang@google.com>
Subject: Re: [PATCH v2] HID: google: add google vivaldi HID driver
In-Reply-To: <20200825085044.1.I170489c0c2ac1538b3890abb5a92b95ad4f04d01@changeid>
Message-ID: <nycvar.YFH.7.76.2008261311550.27422@cbobk.fhfr.pm>
References: <20200825085044.1.I170489c0c2ac1538b3890abb5a92b95ad4f04d01@changeid>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 25 Aug 2020, Sean O'Brien wrote:

> Add Google vivaldi HID driver. This driver allows us to read and report
> the top row layout of keyboards which provide a vendor-defined HID
> usage.

Thanks for the driver.

I actually believe we should follow the standard convention here, and have 
just one hid-<vendor> driver for all google products. Currently we have 
hid-google-hammer, and this would add hid-google-vivaldi. Would you (or 
Wei-Ning, CCing here) object on merging these two together?

It's of course possible to still have hid-google-vivaldi.c and 
hid-google-hammer.c, but then have only one CONFIG_HID_GOOGLE option 
that'd link these two (and pontentially any future ones) into one single 
hid-google.ko.

Thanks,

-- 
Jiri Kosina
SUSE Labs