Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932529AbWEXA4u (ORCPT ); Tue, 23 May 2006 20:56:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932528AbWEXA4t (ORCPT ); Tue, 23 May 2006 20:56:49 -0400 Received: from smtp.osdl.org ([65.172.181.4]:48529 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932525AbWEXA4t (ORCPT ); Tue, 23 May 2006 20:56:49 -0400 Date: Tue, 23 May 2006 17:56:28 -0700 From: Andrew Morton To: Chris Leech Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine Message-Id: <20060523175628.22a741ba.akpm@osdl.org> In-Reply-To: <20060524002013.19403.57410.stgit@gitlost.site> References: <20060524001653.19403.31396.stgit@gitlost.site> <20060524002013.19403.57410.stgit@gitlost.site> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 23 Chris Leech wrote: > > +static void ioat_dma_memcpy_cleanup(struct ioat_dma_chan *chan) > +{ > + unsigned long phys_complete; > + struct ioat_desc_sw *desc, *_desc; > + dma_cookie_t cookie = 0; > + > + prefetch(chan->completion_virt); > + > + if (!spin_trylock(&chan->cleanup_lock)) > + return; > + spin_trylock() is a red flag. It often means that someone screwed their locking up. It at least needs a comment explaining its presence. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/