Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp168904pxa; Wed, 26 Aug 2020 07:36:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwniaxXfo669PSFy97s2/XTFYoLlZkXNmdBgF64kBtGmxFYXirWKKqmFHzHZ0VXgOp8t9jx X-Received: by 2002:aa7:dcc6:: with SMTP id w6mr3541471edu.273.1598452581241; Wed, 26 Aug 2020 07:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598452581; cv=none; d=google.com; s=arc-20160816; b=Sxh/iDlFyR5NNuFCPby/hVc1nlVMaKgKPn9TotHnNNXQjBDmZTQ7RH0tKW2Yr31Ry0 XD/DyzaKM3e6wHrmW2kbtC822WStF/UhKl2d+H4q6jEcSvDKpMv9nJLt7Yc1MRsgiEVv qcPKmDUmfzp2DyAQ+QRhLyvezP0tUhAEXS1ZRj+Php5M9Psh4JOm0/GeOuyCd1voDlUg ViPDE3Plvgw5LAhvpnVEd6yHSQmGkUysK3pRzYWM5xzQwWSAWjqZpV9V14AKUydtFCTB AJQQbqrUd8YqZlXRMLrbYkYycnCmTgHcEqmTi7sBBX3NdzWWAz7gPIMCWtrJesu+1dfB C0xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=hGUTdln7l6OLSRN/oGX5pGuJYKRn/THkz/0Z1CGTGCE=; b=J494zoafBB+jeI0AziSGEX6M13msUTLcePFx8m6nl3YoksZHfTExWRtJpZpW3SOTuF QQGpxn+UVQYQei32Yi0s3SUPiD0wFbKdgmHvGAbnHDSKZsN326XAkXmCexLcO68ik/yJ XXeU8jTicO0iVcoaJhkFMyvIVAFJku5emBOCpZlgsK774L6qYDT0+pqRKZqxIbkqEsbv D5J65xEqzzOIvByYkKRL/vwrEHp6VuQQIhmVSK2CpF+dUHs4RI+4QJbtCourN/yGlDF5 p8rh8tAj0K2/Ibop7Q+XebRUkG43J2FlvWlqdN6W/BzkOjgGKbzCX9leM+lQPBS5Xp+H yKtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u8si1640613ejr.40.2020.08.26.07.35.58; Wed, 26 Aug 2020 07:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730147AbgHZNV0 (ORCPT + 99 others); Wed, 26 Aug 2020 09:21:26 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:34326 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728276AbgHZNVV (ORCPT ); Wed, 26 Aug 2020 09:21:21 -0400 Received: by mail-ot1-f67.google.com with SMTP id k20so1457144otr.1; Wed, 26 Aug 2020 06:21:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hGUTdln7l6OLSRN/oGX5pGuJYKRn/THkz/0Z1CGTGCE=; b=SNzsDPNwvcl7wtAUFh0rJbVCHgzVgv0h1sACI5h+n6JHvXmQp89UG+eDmEmpozDbZ3 1Khbrz0trcgCONf1fC1YMWRzYvBSQ0NSwN3Amgd5rr585hrupWx0okELSY80jFuG1QIG m/tJJ47yW8PS6Y2Pn913q7c9N/reqVXKyZXhMKBj3shqJIdX7sDGDAk9b49XA6H8fRSn 27FD9QZd5pIlYJQvdgGbqBGXFwXrKWpV5akD8YdDfWurN7wlCzOs4amBVTdo3Yk8FaCe H04KO7fQQKb3PeaEKLeIE9oVDV8+VHQDxUfbBa6SU0Qmyv57kJUe22HnMzz7rLb44FXR XsfQ== X-Gm-Message-State: AOAM533m9UDLw9yD7NcSvhNebXp98FjjzEW8bHCeVoAnY3tIRyuxJdWA PLvRW5IrMDdQlSGxyXNrhQWlbWkxKVMQLzf/LlY= X-Received: by 2002:a9d:5c06:: with SMTP id o6mr9985323otk.262.1598448080994; Wed, 26 Aug 2020 06:21:20 -0700 (PDT) MIME-Version: 1.0 References: <20200826120421.44356-1-guilhem@barpilot.io> In-Reply-To: From: "Rafael J. Wysocki" Date: Wed, 26 Aug 2020 15:21:09 +0200 Message-ID: Subject: Re: [PATCH] intel_idle: Add ICL support To: Artem Bityutskiy Cc: Guilhem Lettron , "Rafael J. Wysocki" , Jacob Pan , Len Brown , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 3:18 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > > Just get a reasonably new turbostat (it is part of the kernel tree, you > > can compile it yourself) and run it for few seconds (like 'turbostat > > sleep 10'), get the output (will be a lot of it), and we can check what > > is actually going on with regards to C-states. > > Oh, and if you could do that with and without your patch, we could even > compare things. But try to do it at least with the default (acpi_idle) > configuration. IMO it is way easier to get the information from sysfs.