Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Aug 2020 11:26:31 -0300
From:   Arnaldo Carvalho de Melo <acme@redhat.com>
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Al Grant <al.grant@foss.arm.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, acme@kernel.org
Subject: Re: [PATCH] perf: correct SNOOPX field offset
Message-ID: <20200826142631.GA5351@redhat.com>
References: <9974f2d0-bf7f-518e-d9f7-4520e5ff1bb0@foss.arm.com>
 <20200825174043.GQ1509399@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200825174043.GQ1509399@tassilo.jf.intel.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu:
> On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
> > perf_event.h has macros that define the field offsets in the
> > data_src bitmask in perf records. The SNOOPX and REMOTE offsets
> > were both 37. These are distinct fields, and the bitfield layout
> > in perf_mem_data_src confirms that SNOOPX should be at offset 38.
> 
> Looks good.
> 
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> 
> Probably should have a Fixes: header

Please do so, find the patch that introduced the error, add the Fixes
tag, will help me not having to do it myself :-)

- Arnaldo