Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Deucher, Alexander" <Alexander.Deucher@amd.com>
To:     Joerg Roedel <joro@8bytes.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "Kuehling, Felix" <Felix.Kuehling@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>
CC:     "jroedel@suse.de" <jroedel@suse.de>,
        "Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] iommu/amd: Do not use IOMMUv2 functionality when SME
 is active
Thread-Topic: [PATCH 2/2] iommu/amd: Do not use IOMMUv2 functionality when SME
 is active
Thread-Index: AQHWegTrOX3Oax7ItE+ghg+6kipvEKlKc/iw
Date:   Wed, 26 Aug 2020 14:20:51 +0000
Message-ID: <MN2PR12MB4488AA440120E3775675CB3FF7540@MN2PR12MB4488.namprd12.prod.outlook.com>
References: <20200824105415.21000-1-joro@8bytes.org>
 <20200824105415.21000-3-joro@8bytes.org>
In-Reply-To: <20200824105415.21000-3-joro@8bytes.org>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true;
 MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-08-26T14:20:44Z;
 MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged;
 MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0;
 MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
 MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a3b3e905-9df5-4be6-a8b5-0000d4520fc3;
 MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_enabled: true
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_setdate: 2020-08-26T14:20:38Z
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_method: Standard
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_name: Internal Use Only -
 Unrestricted
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_actionid: 5f141d97-40f7-4517-b376-0000eafaf01b
msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_contentbits: 0
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-08-26T14:20:46Z
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: 62e0af8e-27da-4358-b518-0000281ab297
msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0
authentication-results: 8bytes.org; dkim=none (message not signed)
 header.d=none;8bytes.org; dmarc=none action=none header.from=amd.com;
x-originating-ip: [165.204.10.250]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 532fcf0f-c1c0-46e6-2255-08d849cb3ca4
x-ms-traffictypediagnostic: MN2PR12MB3917:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR12MB39175C57E949CE0773164C45F7540@MN2PR12MB3917.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2803;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: NhlhTDINMvM5cxTo98PlK4a4+xf2OZbsQleVls3w7jpKoLoxdOu8z7QSddf4W5iTzIG5Pf8OrrDpfaKZbJBD+QL6rw2T8qO9wFbk7klEjNgx0SZ8ffD45uxi8sM2S7RsiN+rQeZu22F7hloi260GnDN5vhheIB0UqzJXb2C3NdKvFcR8Eh/FyabPUpKNJfAmR14Pjspi0wpgxtO60YdBty96XszgcM60phZnXB3CRhxkjAeIvCC1POadz33iz+yLyuzqbHQJ88tpAWHfDAC7bInigPFTUBdlj5q5Mcxoj3QAUZFLLoYKBVaAY9URzy/t
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(136003)(39860400002)(366004)(4326008)(33656002)(64756008)(83380400001)(66446008)(66556008)(66946007)(66476007)(76116006)(8676002)(7696005)(8936002)(71200400001)(2906002)(186003)(54906003)(110136005)(52536014)(55016002)(86362001)(9686003)(6506007)(26005)(53546011)(5660300002)(316002)(478600001)(6636002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: bToiZ6cL8csWIh9E3+KkH5euCoZm4ZOrI0E96PJRKWS/ro86MtaiOm0fDrdFyl00J0KTyKBCLyIC8MzWxeRKBtoLoViKE/f0FL1MdhmHz1CyDkuWCY2zhswGdL+A1QgLNTR+RhnMDBbEKi0HPgoIOipzbfGdZLyb5lXpnM38ommMg1mi2Sr/7Cew+qhxb4PWd559c2ycEqbO4hTvGEH9IiLJK+MmraXxkzD9n05zwGQ/e3Lyhpkl8z2xnSv3f8AoP3YrLlEXQTdUsrqL2JgzpVRLeA6BdRH3duYcBvccHfiLqOGV3LPDlGYMY68XM/FmJhA3KOM33eGeTcoCeJRANXfZN++tGmnGI3chlHs7GIOnt0s3/RULcn4ElpeK9n/kSq094EKOjqED+/1OXpI74cnUXnYW4Cz2BqjUUod1GW6PJkuxfO0p4FqZTirkZ5drvfSrfBqxP2JDqsnXl35ywPFVcyXlPYhX+16yPDM2+rpede5nTptnH1cOfrjnBk/b8rgF+MZgEjiAT9hDtItCehu+qY/ruuNHMcepS6Bd/zOiOa5gpJfxe/7h4OT7x9Mh7QpT4oWmTosYVsLa6DuIO0JKjXo7f4SQB5qoAbF4aF6XyfogmK11b8elmpp6muou/zdPA7ZxdPVYxFLw1l01sg==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 532fcf0f-c1c0-46e6-2255-08d849cb3ca4
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2020 14:20:51.6249
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Llu3i++yK1Uy9gH4ywdFw53Kb4xdznrCBkvVRpIH8XQo14wuXpeDDBxGIeQesR2raGosIF+oCmAEOc3v2MSY7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3917
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[AMD Public Use]

+ Felix, Christian

> -----Original Message-----
> From: Joerg Roedel <joro@8bytes.org>
> Sent: Monday, August 24, 2020 6:54 AM
> To: iommu@lists.linux-foundation.org
> Cc: Joerg Roedel <joro@8bytes.org>; jroedel@suse.de; Lendacky, Thomas
> <Thomas.Lendacky@amd.com>; Suthikulpanit, Suravee
> <Suravee.Suthikulpanit@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; linux-kernel@vger.kernel.org
> Subject: [PATCH 2/2] iommu/amd: Do not use IOMMUv2 functionality when
> SME is active
>=20
> From: Joerg Roedel <jroedel@suse.de>
>=20
> When memory encryption is active the device is likely not in a direct map=
ped
> domain. Forbid using IOMMUv2 functionality for now until finer grained
> checks for this have been implemented.
>=20
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
>  drivers/iommu/amd/iommu_v2.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/drivers/iommu/amd/iommu_v2.c
> b/drivers/iommu/amd/iommu_v2.c index c259108ab6dd..0d175aed1d92
> 100644
> --- a/drivers/iommu/amd/iommu_v2.c
> +++ b/drivers/iommu/amd/iommu_v2.c
> @@ -737,6 +737,13 @@ int amd_iommu_init_device(struct pci_dev *pdev,
> int pasids)
>=20
>  	might_sleep();
>=20
> +	/*
> +	 * When memory encryption is active the device is likely not in a
> +	 * direct-mapped domain. Forbid using IOMMUv2 functionality for
> now.
> +	 */
> +	if (mem_encrypt_active())
> +		return -ENODEV;
> +
>  	if (!amd_iommu_v2_supported())
>  		return -ENODEV;
>=20
> --
> 2.28.0