Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp207149pxa;
        Wed, 26 Aug 2020 08:30:45 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyw9UZYDJhQeWX4q1wZiPQvAhXmSeByTCILAmRXmEWwX5F2y3RxSvN+IGZiYlUCgf7oQq63
X-Received: by 2002:a17:906:22d6:: with SMTP id q22mr8526077eja.242.1598455844783;
        Wed, 26 Aug 2020 08:30:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598455844; cv=none;
        d=google.com; s=arc-20160816;
        b=Mcl12eXyXfDv8lZx7tIVz8Cx8CwhiVwL4fA46DMPaHB5WSF3lF7c/ezVm3OaRzoQm3
         2e/h9x1vaOGmdsJOohlNuDNivmlFjzVirNhOdAF+0fs8ZUfkl7l7Sm0JYIG4WLKFHe4q
         SFZU2vhWitEuwx1AXm8K25GxdBJHL9REZbyGwfTIY8FMByGgMl/H0Wwz2frBvkff8KVE
         vJ9H0qH6gj3DMVSTpGPKWn1DDxcwWCb5ZoiVHpHOEuPIiVoFmB9FReGOk+IcJ/SwUiIl
         TFpWlTVaHz05yApoVBEtUXTnCP0FmJywHdpvPMEpXzRW7mORq9y89QdorivUpf8+0Lbj
         sZmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=4ia6LylQoiMEStYlXhEnKgAOsFtjsW+ZIG1eCYaipqg=;
        b=Ng/WJf20nzfgeySlLO9pdaWkezNwtn+sqxZsUdYcBnybUqgn15TpgVzWygrCZHAc2d
         7Rqng3HN7CFfcad/FEd0gheZQYHbw7QDE8Fb7wH0LtKIyN/6+Yga62DyPDRWMWC/QZ4b
         hJmswtOrVfFgQLQTWNUYHOY39MffGRmVLjfYb9OHzPd9x6BPSo+oOFWj4C7yYriWJKXx
         7KJtGPdVO3EoAQ2gfMpnpeP9tdH11xeJRPODnKJH08loKAZt8ys1KMG0zPgbr0/S/UP9
         5s2PytuvUhjPnYUDH8SuETwJ/4m4xlnQAidmFdfZiIc4TZcEyThOshGVSpyr2Cgv2f0t
         kkcg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id i7si1710560ejf.217.2020.08.26.08.30.20;
        Wed, 26 Aug 2020 08:30:44 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727807AbgHZP31 (ORCPT <rfc822;daisukeokaopensource@gmail.com>
        + 99 others); Wed, 26 Aug 2020 11:29:27 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39774 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727008AbgHZP30 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Aug 2020 11:29:26 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65154C061574;
        Wed, 26 Aug 2020 08:29:26 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 18072135985CB;
        Wed, 26 Aug 2020 08:12:39 -0700 (PDT)
Date:   Wed, 26 Aug 2020 08:28:57 -0700 (PDT)
Message-Id: <20200826.082857.584544823490249841.davem@davemloft.net>
To:     aranea@aixah.de
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] veth: Initialize dev->perm_addr
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200826152000.ckxrcfyetdvuvqum@vega>
References: <20200824143828.5964-1-aranea@aixah.de>
        <20200824.102545.1450838041398463071.davem@davemloft.net>
        <20200826152000.ckxrcfyetdvuvqum@vega>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Aug 2020 08:12:39 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Mira Ressel <aranea@aixah.de>
Date: Wed, 26 Aug 2020 15:20:00 +0000

> I'm setting the peer->perm_addr, which would otherwise be zero, to its
> dev_addr, which has been either generated randomly by the kernel or
> provided by userland in a netlink attribute.

Which by definition makes it not necessarily a "permanent address" and
therefore is subject to being different across boots, which is exactly
what you don't want to happen for automatic address generation.