Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200826134315.GA3882506@kroah.com> <CGME20200826150239eucas1p24c59716cc31edfeb2eece84d97936b93@eucas1p2.samsung.com>
 <1425ab4f-ef7e-97d9-238f-0328ab51eb35@samsung.com> <20200826153347.GB4187816@kroah.com>
In-Reply-To: <20200826153347.GB4187816@kroah.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 26 Aug 2020 18:53:02 +0300
Message-ID: <CAHp75VepkugjZ4pvdNgxzT4T83ewL1AFtSZZtVq6aL+7=sqskA@mail.gmail.com>
Subject: Re: [GIT PULL] USB fixes for 5.9-rc3
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Brooke Basile <brookebasile@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>,
        Ilja Van Sprundel <ivansprundel@ioactive.com>,
        Kees Cook <keescook@chromium.org>,
        Felipe Balbi <balbi@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Content-Type: multipart/mixed; boundary="00000000000090e62b05adc9d19e"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--00000000000090e62b05adc9d19e
Content-Type: text/plain; charset="UTF-8"

On Wed, Aug 26, 2020 at 6:36 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Aug 26, 2020 at 05:02:38PM +0200, Marek Szyprowski wrote:
> > On 26.08.2020 15:43, Greg KH wrote:

> > > Brooke Basile (2):
> > >        USB: gadget: u_f: add overflow checks to VLA macros
> >
> > Sorry, but the above patch breaks USB Ethernet Gadget operation. It also
> > didn't get the proper testing in linux-next (next-20200826 is the first
> > one with this patch).
> >
> > This is how it explodes on Samsung Exynos (ARM 32bit) based board with
> > g_ether module loaded:

> Odd, for a "normal" descriptor, the logic should have remained the same
> as without this patch.

> Brooke, any ideas?

I have an idea.

Does below fix this?


-- 
With Best Regards,
Andy Shevchenko

--00000000000090e62b05adc9d19e
Content-Type: text/x-patch; charset="US-ASCII"; name="1.diff"
Content-Disposition: attachment; filename="1.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_kebk4tac0>
X-Attachment-Id: f_kebk4tac0

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2dhZGdldC91X2YuaCBiL2RyaXZlcnMvdXNiL2dhZGdl
dC91X2YuaAppbmRleCBkZjRlMWRjYjM1N2QuLjBiNWM1ZjBkZDA3MyAxMDA2NDQKLS0tIGEvZHJp
dmVycy91c2IvZ2FkZ2V0L3VfZi5oCisrKyBiL2RyaXZlcnMvdXNiL2dhZGdldC91X2YuaApAQCAt
MjUsOCArMjUsOCBAQAogCQlzaXplX3Qgb2Zmc2V0ID0gMDsJCQkJCSAgICAgICBcCiAJCWlmIChn
cm91cG5hbWUjI19fbmV4dCAhPSBTSVpFX01BWCkgewkJCSAgICAgICBcCiAJCQlzaXplX3QgYWxp
Z25fbWFzayA9IF9fYWxpZ25vZl9fKHR5cGUpIC0gMTsJICAgICAgIFwKLQkJCXNpemVfdCBvZmZz
ZXQgPSAoZ3JvdXBuYW1lIyNfX25leHQgKyBhbGlnbl9tYXNrKSAgICAgICBcCi0JCQkJCSAmIH5h
bGlnbl9tYXNrOwkJCSAgICAgICBcCisJCQlvZmZzZXQgPSAoZ3JvdXBuYW1lIyNfX25leHQgKyBh
bGlnbl9tYXNrKSAmCSAgICAgICBcCisJCQkJICB+YWxpZ25fbWFzazsJCQkJICAgICAgIFwKIAkJ
CXNpemVfdCBzaXplID0gYXJyYXlfc2l6ZShuLCBzaXplb2YodHlwZSkpOwkgICAgICAgXAogCQkJ
aWYgKGNoZWNrX2FkZF9vdmVyZmxvdyhvZmZzZXQsIHNpemUsCQkgICAgICAgXAogCQkJCQkgICAg
ICAgJmdyb3VwbmFtZSMjX19uZXh0KSkgeyAgICAgICAgICBcCkBAIC00Myw4ICs0Myw4IEBACiAJ
CXNpemVfdCBvZmZzZXQgPSAwOwkJCQkJCVwKIAkJaWYgKGdyb3VwbmFtZSMjX19uZXh0ICE9IFNJ
WkVfTUFYKSB7CQkJCVwKIAkJCXNpemVfdCBhbGlnbl9tYXNrID0gX19hbGlnbm9mX18odHlwZSkg
LSAxOwkJXAotCQkJc2l6ZV90IG9mZnNldCA9IChncm91cG5hbWUjI19fbmV4dCArIGFsaWduX21h
c2spCVwKLQkJCQkJICYgfmFsaWduX21hc2s7CQkJCVwKKwkJCW9mZnNldCA9IChncm91cG5hbWUj
I19fbmV4dCArIGFsaWduX21hc2spICYJCVwKKwkJCQkgIH5hbGlnbl9tYXNrOwkJCQkJXAogCQkJ
aWYgKGNoZWNrX2FkZF9vdmVyZmxvdyhvZmZzZXQsIGdyb3VwbmFtZSMjXyMjbmFtZSMjX19zeixc
CiAJCQkJCQkJJmdyb3VwbmFtZSMjX19uZXh0KSkgewlcCiAJCQkJZ3JvdXBuYW1lIyNfX25leHQg
PSBTSVpFX01BWDsJCQlcCg==
--00000000000090e62b05adc9d19e--