Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: zgFv1I5c4/t1Q8NdD/Ix5F+zSFXgO9th07AHnI7ZPgD7OVEr+rV/ffbB0PQaLXYFK1gYkFlzpT
 NMiIoHkdgg9Q==
IronPort-SDR: fvLsOD2XMoMTI8CwlzG9v6oMPe4Fs+jHmWvidaxwI72ZZBN5XcXQpqYJHNWk7bGswAONcg0riO
 RX+QyS6HboJQ==
Date:   Wed, 26 Aug 2020 18:55:07 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Joe Perches <joe@perches.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1] driver core: Annotate dev_err_probe() with
 __must_check
Message-ID: <20200826155507.GV1891694@smile.fi.intel.com>
References: <20200826104459.81979-1-andriy.shevchenko@linux.intel.com>
 <9635eaa4ccc1141fb0dd8c3687f46da7149206ad.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9635eaa4ccc1141fb0dd8c3687f46da7149206ad.camel@perches.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote:
> On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote:

...

> > -int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
> > +int __must_check dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
> 
> Generally, the __must_check should go before the return type
> and the extern isn't necessary and is also generally not used
> in device.h, so I'd prefer:
> 
> __printf(3, 4)
> __must_check int dev_err_probe(...);

I grepped the current code... I don't see support of your preference.
Maybe I missed something? (I'm talking about include/*)

-- 
With Best Regards,
Andy Shevchenko