Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Aug 2020 19:09:50 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>
Cc:     Mark Brown <broonie@kernel.org>, Qiang Zhao <qiang.zhao@nxp.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pankaj Bansal <pankaj.bansal@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Tanveer Alam <tanveer.alam@puresoftware.com>
Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
Message-ID: <20200826160950.i3k2oy6w2dlvmj34@skbuf>
References: <20200821131029.11440-1-kuldip.dwivedi@puresoftware.com>
 <20200821140718.GH4870@sirena.org.uk>
 <c810740d75f64e308fd362e6c6a5f437@mail.gmail.com>
 <20200822152118.rlwbcgfk4abjldtg@skbuf>
 <VE1PR04MB6768699B6D7A507A5BF82F9191540@VE1PR04MB6768.eurprd04.prod.outlook.com>
 <20200826114758.4agph53ag2fin6um@skbuf>
 <20200826142312.GH4965@sirena.org.uk>
 <20200826144744.c4yzgoovk6f4t3id@skbuf>
 <2e19f8979be4f962045a1597bdbe7886@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2e19f8979be4f962045a1597bdbe7886@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 26, 2020 at 08:43:20PM +0530, Kuldip Dwivedi wrote:
> Just a query, Can't we use meaningful HID for different SoC just like
> compatible strings in DT ?
> In this way Silicon parameters can also be added in
> fsl_dspi_devtype_data structure , which is already exist in driver

I don't know, is that the preferred way?
I don't even know if NXP0005 is made up or if it's written down
somewhere in the PNP ID registry. NXP0006 seems to be assigned to the
MDIO controller already, so the list of _HID values for the DSPI
controller would be discontiguous at best, as well as ever-growing.
Again, I'm just raising the concern, if somebody comes in and declares
that as "not a problem", then ok.
In the ACPI spec there's also a _HRV (Hardware Revision) object, which
comes as a simple DWORD. We could use acpi_evaluate_integer() to read
that, and use it as index into the array of fsl_dspi_devtype_data, if
we declare that as ABI within the driver (and new SoCs would be added
only at the end of the enum). Then we could use the NXP0005 _HID for
everything DSPI.
Again, maybe somebody could chime in and guide us on what's preferable.

Thanks,
-Vladimir