Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp252560pxa; Wed, 26 Aug 2020 09:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3ZoVAf6WiqKcaTjPXTQp9Q17VTbDP5+50riaehdRErw9s5/XcmceDyE7Ii6tyZtYDH9eu X-Received: by 2002:a17:906:4a99:: with SMTP id x25mr17260189eju.439.1598459948844; Wed, 26 Aug 2020 09:39:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598459948; cv=none; d=google.com; s=arc-20160816; b=m8aNHsVMAPM21LoqL4S/LFstBWRg373c3s/FNczVyz3nmY4DArAqNsX+TlWsYhczJl hXTDJXdABYOaKSdMsun/67/6cF0SFr7dTW27SY1TIc8YF/7aZ5QV0pNC6Y/cCdPefviO ju/vNNXVpS06lTQEuEaAVt7VTkUyMoMDld6diVXArlQ7bfh/CaRqla+sHnbC+9RJ87+d HvrNE6yzBJQ2AYyPZS6VBGPfhq2fzsdX7J5g41aFlUUf271RG+foTy3rJXIMHBhhX9zq O4l8/CMLyBiLw3XkvwJK89YLpIaRAhLQb01oKGQVux7HSQXF/eUvwlsgjQtTwJm3lU4+ 2U/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=H9QKRsn3Hoq2NW5w/2vX6w6Cdab5FAgIDXygM4SSaM4=; b=hZFkiaYmeDX63y5YzfjDKSyIuGYjBaWhi6c0pyK8BxgDS4CcDPqcNwIIMdLnuUz5KB 4tl/rE/sGFLrEeDXktN+ZxgdXi1WoshHQHgURwmgAzvXgKemL7/PU/MCWXWIYklamVqN RAiJPHqR6vEusMNTzCiacjC1casX1EbCixpSXj9MJIA35GehA707bntE/3Fym5sFHoyE GLyJC23ZXCVaFkiQCUfKOPk2ahFbAGLksn5/mm8oov5Psd8UTHDUvf3VKHrNcj8NADEf 6oOqTUhDl9lzOPNHHqgYt/c7BcdJKpGPcM0lNxEkZBrSpah1+Av2qf0YdX/0JK/s+qdy 8EGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=YypZ4VZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=marvell.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a19si1711482edn.223.2020.08.26.09.38.46; Wed, 26 Aug 2020 09:39:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=YypZ4VZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728105AbgHZQfG (ORCPT + 99 others); Wed, 26 Aug 2020 12:35:06 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:31156 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbgHZQe7 (ORCPT ); Wed, 26 Aug 2020 12:34:59 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07QGUOTL026509; Wed, 26 Aug 2020 09:34:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : in-reply-to : message-id : references : mime-version : content-type; s=pfpt0220; bh=H9QKRsn3Hoq2NW5w/2vX6w6Cdab5FAgIDXygM4SSaM4=; b=YypZ4VZY5KIiioCIigwXPjpWp+cFlIem+jvkWUnsne0l+0Ysg25KsrRKroFDTUXQVLwt PleAzdORW+g5IexUwvGkaabvhcp8J0QW3jS+7tbACJuNxVH2r6Mo0zJqcHu5mLdAUGpl c+9lKf9NSCKjy2wSIurZPbiWF3ySU5HY20Nj/EuH49kHtMfK912RncTmy8byBq3WBbig jp8wEmSWbQIj+Iv+q8OrdHfTBXoX6YeE22Dh5iDIyuJNWg2xtB2BtqL3WI+CwCj30b8g fDIJmvfTcr80x2NjwNIeukF+/JYcfmrU21ccs1OyYeygKiD945pTU2Z/fKBm9JXOVph2 pA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 3332vn1md5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 26 Aug 2020 09:34:56 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 26 Aug 2020 09:34:54 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 Aug 2020 09:34:54 -0700 Received: from irv1user01.caveonetworks.com (unknown [10.104.116.179]) by maili.marvell.com (Postfix) with ESMTP id 620893F703F; Wed, 26 Aug 2020 09:34:54 -0700 (PDT) Received: from localhost (aeasi@localhost) by irv1user01.caveonetworks.com (8.14.4/8.14.4/Submit) with ESMTP id 07QGYrZa029186; Wed, 26 Aug 2020 09:34:53 -0700 X-Authentication-Warning: irv1user01.caveonetworks.com: aeasi owned process doing -bs Date: Wed, 26 Aug 2020 09:34:53 -0700 From: Arun Easi X-X-Sender: aeasi@irv1user01.caveonetworks.com To: Alex Dewar CC: Nilesh Javali , , "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH] scsi: qla2xxx: Remove unnecessary call to memset In-Reply-To: Message-ID: References: <20200820185149.932178-1-alex.dewar90@gmail.com> User-Agent: Alpine 2.21.9999 (LRH 334 2019-03-29) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-26_10:2020-08-26,2020-08-26 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2020, 2:42pm, Alex Dewar wrote: > > On 2020-08-20 19:51, Alex Dewar wrote: > > In qla25xx_set_els_cmds_supported(), a call is made to > > dma_alloc_coherent() followed by zeroing the memory with memset. This is > > unnecessary as dma_alloc_coherent() already zeros memory. Remove. > > > > Issue identified with Coccinelle. > > > > Signed-off-by: Alex Dewar > Gentle ping? > > --- > > drivers/scsi/qla2xxx/qla_mbx.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c > > index 226f1428d3e5..e00f604bbf7a 100644 > > --- a/drivers/scsi/qla2xxx/qla_mbx.c > > +++ b/drivers/scsi/qla2xxx/qla_mbx.c > > @@ -4925,8 +4925,6 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t *vha) > > return QLA_MEMORY_ALLOC_FAILED; > > } > > - memset(els_cmd_map, 0, ELS_CMD_MAP_SIZE); > > - > > /* List of Purex ELS */ > > cmd_opcode[0] = ELS_FPIN; > > cmd_opcode[1] = ELS_RDP; > > Looks good. Regards, -Arun