Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] memory: emif: Remove bogus debugfs error handling
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Santosh Shilimkar <ssantosh@kernel.org>
Cc:     Krzysztof Kozlowski <krzk@kernel.org>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <20200826113759.GF393664@mwanda>
From:   santosh.shilimkar@oracle.com
Organization: Oracle Corporation
Message-ID: <10387fe0-579a-de71-44ad-ac585ff604d6@oracle.com>
Date:   Wed, 26 Aug 2020 09:52:37 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200826113759.GF393664@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/26/20 4:37 AM, Dan Carpenter wrote:
> Callers are generally not supposed to check the return values from
> debugfs functions.  Debugfs functions never return NULL so this error
> handling will never trigger.  (Historically debugfs functions used to
> return a mix of NULL and error pointers but it was eventually deemed too
> complicated for something which wasn't intended to be used in normal
> situations).
> 
> Delete all the error handling.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Looks good to me !!

Acked-by: Santosh Shilimkar <ssantosh@kernel.org>