Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp263004pxa; Wed, 26 Aug 2020 09:56:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5uQDAbXx6j0tm/jEL/5jNfhBfRCsvTQ3wXrdYfLC4fJBX5yIx9pyvR4QR7cDPKTn602kO X-Received: by 2002:a05:6402:6d9:: with SMTP id n25mr10470570edy.149.1598460999320; Wed, 26 Aug 2020 09:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598460999; cv=none; d=google.com; s=arc-20160816; b=tpL14rNDBFo9UQqCm3lAF9nOfoNLu24FeQ0ODP+d2GgHsudWw00U0u7dNl/HLQz20h zlXLSzUtuFix3lEvidcUlfVZP72NmmC90ycWV/DezAdxuO3K5qZGmns0S6ot6BeVAquK 3qmOibCOkaDWJO7YMxACZ/HsVP38kRkK2KoZsMuYXqK/4j9qLvBHcs+Il95N34s8PBbN rAHeb+Q5nxIwmtUNdIOffVnwpBjY87wntxq31Nr+DoTvP6+NKMxVzzrFNbODEdirvTem wswJBZHHCAlG/tiN562CUDWqp+hGHw2+QtTo9a6TzRvv/vaqFvgeQ5PTwl0uitVrOrZR acxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yvbxB/dXm+wxQXgZYoFFZEVL9w4GvstjJ1BXu6Uy/Hc=; b=HtbrEDs0yqR02Hc4ZJ1nI0k6PQm9zQWUXLSnjv/jnjidWLtM37w9/uLRmfKHdfhfyB R0GugQzRsrPZsg64hbY8kakZTrXFJREurZMOCdDb7WCelxl+w+RWrVAm2H7mxNWgNjCG umyygYY39f2XE15k5JIGb6ofwMZD9lqQreYbBli3/BoyUyhF1cnoYvuskfouQ/S6DH4u WCLD7d5jRC2uSA8c/MOxhm1DLlL2WkCJ94wauli+lJWhPAeCYBUwZhqS44AgKgv1f112 sJv1fhPrTNUjJbelGqZF/auJj3pyZP61QlC2lRzA5JlAJJ8ZwrliG9Al6LyQRbMRQc9e f0hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G+EeWxWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q6si1733804edh.358.2020.08.26.09.56.15; Wed, 26 Aug 2020 09:56:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G+EeWxWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgHZQxq (ORCPT + 99 others); Wed, 26 Aug 2020 12:53:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:49366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbgHZQxo (ORCPT ); Wed, 26 Aug 2020 12:53:44 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1DD32078B; Wed, 26 Aug 2020 16:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598460824; bh=yvbxB/dXm+wxQXgZYoFFZEVL9w4GvstjJ1BXu6Uy/Hc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G+EeWxWlvWkzBLDIG4YwXEVSUsPzaMdlqtMCM2GTdCgivysepguirOTd+5lMVVyNl i9dtROwHC76N4bjFqFddps3JLinWLMBAsEFpP1G3l7IiTW4xAaIG1kIJy28biGFpXk WCvP/u2YDSt5umUXhfoBNoy72IC0sT2M2Ob2p7Ns= Date: Wed, 26 Aug 2020 17:53:08 +0100 From: Mark Brown To: Tang Bin Cc: timur@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zhang Shengju Subject: Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe() Message-ID: <20200826165308.GJ4965@sirena.org.uk> References: <20200826150918.16116-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="W/D3X8sky0X3AmG5" Content-Disposition: inline In-Reply-To: <20200826150918.16116-1-tangbin@cmss.chinamobile.com> X-Cookie: Should I do my BOBBIE VINTON medley? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --W/D3X8sky0X3AmG5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Why is this an issue - the check will make things more robust if someone manages to load the driver on a non-DT system and otherwise costs us a couple of instructions? --W/D3X8sky0X3AmG5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9Gk3MACgkQJNaLcl1U h9AXowf+OVsKdeEZ3BjfcRZvF73cSt5ZNgBH2LZFoif+p5duvwFhYWYpiM838REI CFWQz5uaMwq5pzA8Hx+iJA+HyEhiucpXw3yxW5Xs0j1nd/BgiSGKdyHlTXZ3RqD4 Gr2QdQXO17esiaT11+ZLFIwecynN29JLQ8GThARSMc7tGfmaXy5JQJkOy5c4nOFX ycF3dds18vEua7ajqC3wFLTDygdqE6gv41YqIJgU3J9X/tAugKh1jtTa4k1eh/6M ydH9ezNoA3havqWqAAhAGbW3kbLBCQFKsndWnZbYPU0VHZw5shBWTrx2+x6z8F68 YM/0TyIgmkvB07oBBF6wkjb5sD0hZA== =6aKW -----END PGP SIGNATURE----- --W/D3X8sky0X3AmG5--