Date: Wed, 24 May 2006 07:34:47 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Arjan van de Ven <arjan@infradead.org>,
       Linus Torvalds <torvalds@osdl.org>, jakub@redhat.com,
       rusty@rustcorp.com.au, kraxel@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps
Message-ID: <20060524053447.GA1934@elte.hu>
References: <20060523000126.GC9934@elte.hu> <44738C0C.9010107@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44738C0C.9010107@vmware.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 931
Lines: 29


* Zachary Amsden <zach@vmware.com> wrote:

> >+	if (current->mm)
> >+		printk("vDSO at %p\n", current->mm->context.vdso);
> >+#endif
> > 	show_regs(regs);
> >+	printk("\n");
> >+	print_vmas();
> > }
> > 
> > static int __init setup_print_fatal_signals(char *str
> 
> Perhaps I should have read your first patch more carefully - it did 
> have register info.  This looks even better (although you may now want 
> to allow it to be #ifdef'd out under CONFIG_EMBEDDED).
> 
> You probably should use PATH_MAX+1 instead of SIZE or check IS_ERR() 
> on the string from d_path.

the string is constructed on the stack, so 4K would be too much. 128 is 
i think enough for most purposes.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/