Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp317937pxa; Wed, 26 Aug 2020 11:25:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZ5Zft9IOLQZGNaqBcSsS7BNp95ApX1xeXKWaWPHOMcTMmFXB9rq0+Q+VHZke76j7z3owB X-Received: by 2002:a50:ec89:: with SMTP id e9mr8002370edr.32.1598466341454; Wed, 26 Aug 2020 11:25:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598466341; cv=none; d=google.com; s=arc-20160816; b=M3Bhoww6gInVwoCwHQG5mSdcCRESFJ2D42OSBpUTVgQFDuzf/XUqx9h05w5xiIUtx7 P1pIR5mJWG7HP2rLX028RPOr09xViSqZFFpi01N1JBKTifRkH8j4BClkb8WnKT4Zxbft ltbksspFD0B0qIImzNcS82fb8LKIwLKZGZbk3fp+J7UJNj7V6pxMGuDh/P6BCq3Uby4G jcjaFbn5phWO/o0qxPbkDdzNKzTIkjeUTi05lIpr3kxcHtMHGqQ8wuXysBjWLVj+dnN0 IqxTaM6xwOSgWAUcBi0WwkI+1q9L22Cw6PVjOI7vyH8bmTeYXfxU7+za9ppYq1C+mDmV +l0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=47B2W9chqSleNpfDGutHaxEQjzT9C3+pWqaOpYKfY50=; b=fC8csj+VjZIyLFa8HnQx05rX/nEOUBnsGcnvE/eTkd3aRY+3l4OOgjD0Wdx/fB83ta 7B/Dz3g64fl8GqxFx/0cUTRjPeMw+8emvPBhgQocQaJ96z2JPRVdQpwB1FDfrU2D0es0 CojlJVRXSEANu+tmB1I15Db7LI/Z3HI7/XxCoh726BKwANK4BPB/2endyfjVYhx9Pin7 hEgNdme8RyFbmkfdTrKb2OxCFWNoRA4VEbavxyD0C6zTEQZ/YB6RF1w3jYFtsvJxJZ3I eOeioc+W2wp+kxxGRavIuV/WTfyCQ641/xZB/oQ9IW2kYqSzXersQiSaodbcSpRcCf/v ihAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si2188325edx.86.2020.08.26.11.25.18; Wed, 26 Aug 2020 11:25:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbgHZSWj (ORCPT + 99 others); Wed, 26 Aug 2020 14:22:39 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39111 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726241AbgHZSWh (ORCPT ); Wed, 26 Aug 2020 14:22:37 -0400 Received: by mail-ed1-f65.google.com with SMTP id c10so2593751edk.6; Wed, 26 Aug 2020 11:22:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=47B2W9chqSleNpfDGutHaxEQjzT9C3+pWqaOpYKfY50=; b=PbNx2hzX7W/T0GGXa9B88D3soPnMMENlLihfgZ8FzFbjE9b8QQZOZ/1XShjOqbtFdz USxIJNfPzlQwIWXqSw5RU+WmRN7735lcA7obYZgIuBWSGR5KxqXfw//5AasaZiia8deu h4sHGKnUJ4fdY9/Fyu7UPtxku2U5VVkVelpO8xya8G8wfdeI56TezV8cQKoCY5QG/Q4l PMmuUiFVwNj8uVDX1suZLFucTrxIqClbP/lcEstE40JwM7pej5zV6YzYGuhAhK0+3X3d X0w/qD9BjATTRgSo0YQ4OETNoHa2IveuVfgHdMui5WCLk8CSiTf4cAvn6J3OhsrdlG0s 4s3A== X-Gm-Message-State: AOAM533HbuNE/BulVDMU4U29CvnkwRaZFrqzOQ1PLL4BipCT9V4XgJyE RLPmxomTGP31z89QaUQppt4= X-Received: by 2002:a05:6402:1b02:: with SMTP id by2mr12999107edb.95.1598466155084; Wed, 26 Aug 2020 11:22:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id a23sm2954376eju.43.2020.08.26.11.22.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Aug 2020 11:22:34 -0700 (PDT) Date: Wed, 26 Aug 2020 20:22:32 +0200 From: Krzysztof Kozlowski To: Dan Carpenter Cc: Roger Quadros , Tony Lindgren , Jon Hunter , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] memory: omap-gpmc: Fix a couple off by ones Message-ID: <20200826182232.GA11327@kozik-lap> References: <20200825104707.GB278587@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200825104707.GB278587@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 25, 2020 at 01:47:07PM +0300, Dan Carpenter wrote: > These comparisons should be >= instead of > to prevent reading one > element beyond the end of the gpmc_cs[] array. > > Fixes: cdd6928c589a ("ARM: OMAP2+: Add device-tree support for NOR flash") > Fixes: f37e4580c409 ("ARM: OMAP2: Dynamic allocator for GPMC memory space") > Signed-off-by: Dan Carpenter > --- > drivers/memory/omap-gpmc.c | 4 ++-- Thanks, applied. Best regards, Krzysztof