Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <9bfb4c4bd1415a8ce527a913730672508a8e8330.camel@perches.com>
Subject: Re: [PATCH v3 2/2] dynamic debug: allow printing to trace event
From:   Joe Perches <joe@perches.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        jbaron@akamai.com, mingo@redhat.com,
        Nicolas Boichat <drinkcat@chromium.org>, kernel@axis.com,
        corbet@lwn.net, pmladek@suse.com, sergey.senozhatsky@gmail.com,
        john.ogness@linutronix.de, linux-kernel@vger.kernel.org
Date:   Wed, 26 Aug 2020 12:53:57 -0700
In-Reply-To: <20200826153203.1a65c35d@oasis.local.home>
References: <20200825153338.17061-1-vincent.whitchurch@axis.com>
         <20200825153338.17061-3-vincent.whitchurch@axis.com>
         <651f7ec449dfb28006bbc0b018d4f6e506bcda80.camel@perches.com>
         <20200826153203.1a65c35d@oasis.local.home>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-08-26 at 15:32 -0400, Steven Rostedt wrote:
> On Tue, 25 Aug 2020 08:53:25 -0700
> Joe Perches <joe@perches.com> wrote:
> 
> > > The print buffer is statically allocated and managed using code borrowed
> > > from __ftrace_trace_stack() and is limited to 256 bytes (four of these
> > > are allocated per CPU to handle the various contexts); anything larger
> > > will be truncated.  
> > 
> > There is an effort to avoid using trace_printk and the like
> > so perhaps this feature should have the same compile time
> > guard.
> 
> No, this is fine for being in a production kernel. Basically, these are
> simply debug printk()s that can also be put into the trace buffer. The
> key difference to trace_printk() is that they are an event that needs
> to be enabled to write into the buffer.

It just seems like a backdoor way to convert various pr_debug functions
(dev_dbg/netdev_dbg, et al) into tracing.

What's the real value?  Timing data?  Something else?